You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2008/10/13 08:08:51 UTC
Re: svn commit: r33604 - trunk/subversion/tests/cmdline
On Sun, Oct 12, 2008 at 6:47 AM, <ju...@tigris.org> wrote:
>...
\> # diff r2 against working copy
> - diff_repos_wc = [
> - "Index: A/mucopy\n",
> - "===================================================================\n",
> - "--- A/mucopy\t(revision 2)\n",
> - "+++ A/mucopy\t(working copy)\n",
> + diff_repos_wc = make_diff_header("A/mucopy", "revision 2", "working copy")
> + diff_repos_wc += [
(nit)
All the other functions do +[ on the end of the first line. This one
breaks that style with the += ...
Cheers,
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33604 - trunk/subversion/tests/cmdline
Posted by Julian Foad <ju...@btopenworld.com>.
On Mon, 2008-10-13 at 01:08 -0700, Greg Stein wrote:
> On Sun, Oct 12, 2008 at 6:47 AM, <ju...@tigris.org> wrote:
> >...
> \> # diff r2 against working copy
> > - diff_repos_wc = [
> > - "Index: A/mucopy\n",
> > - "===================================================================\n",
> > - "--- A/mucopy\t(revision 2)\n",
> > - "+++ A/mucopy\t(working copy)\n",
> > + diff_repos_wc = make_diff_header("A/mucopy", "revision 2", "working copy")
> > + diff_repos_wc += [
>
> (nit)
> All the other functions do +[ on the end of the first line. This one
> breaks that style with the += ...
Adding " + [" would have made the line at least 80 characters long. I
could have moved the last argument onto a new line, though. That would
perhaps have been better. I did check that "+=" is supported in Python
2.2.
Thanks for your attention to detail. I do appreciate it. I think the
same way myself, but just made a different decision in this case.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org