You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/07 13:19:33 UTC

[GitHub] [arrow] raulcd commented on a diff in pull request #12816: ARROW-16025: [Python][C++] Fix segmentation fault when closing ORCFileWritter

raulcd commented on code in PR #12816:
URL: https://github.com/apache/arrow/pull/12816#discussion_r845126064


##########
cpp/src/arrow/adapters/orc/adapter_test.cc:
##########
@@ -406,6 +423,10 @@ TEST(TestAdapterRead, ReadIntAndStringFileMultipleStripes) {
 
 // Trivial
 
+class TestORCWriterTrivialNoWrite : public ::testing::Test {};
+TEST_F(TestORCWriterTrivialNoWrite, noWrite) {
+  TestORCWriterNoWrite(kDefaultSmallMemStreamSize / 16);

Review Comment:
   There is no real reason. I was following the convention I saw for the other tests on `adapter_test.cc` but I have pushed bcadad3eacdf505807c02f1823932ed285e07be8 removing the helper function as I agree with it not being necessary. Thanks!
   I've also fixed the minor linting issue on the same commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org