You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2013/07/12 11:25:48 UTC

[jira] [Commented] (DIRMINA-948) Performance recession when invoke session.write concurrent

    [ https://issues.apache.org/jira/browse/DIRMINA-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706815#comment-13706815 ] 

Emmanuel Lecharny commented on DIRMINA-948:
-------------------------------------------

Good catch !!! 
                
> Performance recession when invoke session.write concurrent
> ----------------------------------------------------------
>
>                 Key: DIRMINA-948
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-948
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.7
>            Reporter: Mark
>              Labels: performance
>
> In org.apache.mina.core.filterchainDefaultIoFilterChain, code around line number 600, 
> <code>if (writeRequestQueue.size() == 0 )</code>
> will raise performance problem in high concurrent situation, Mina default use ConcurrentLinkedQueue as writeRequestQueue, but size() of this queue is not a constant-time operation, suggest to use <code>if (writeRequestQueue.isEmpty(s))</code> instead of it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira