You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2008/07/07 18:57:50 UTC
[jira] Commented: (OFBIZ-1864) New and improved Italian labels
[ https://issues.apache.org/jira/browse/OFBIZ-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611238#action_12611238 ]
Adrian Crum commented on OFBIZ-1864:
------------------------------------
Bruno,
A couple of things I noticed in your patch:
1. Thai labels are changed. Was that intentional?
2. Some of your "improved" labels only change upper case letters to lower case letters. I believe the "de facto" best practice for field labels is to capitalize each word. Sentences would have only the first word capitalized, of course.
> New and improved Italian labels
> -------------------------------
>
> Key: OFBIZ-1864
> URL: https://issues.apache.org/jira/browse/OFBIZ-1864
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: italian_labels.patch
>
>
> Please find attached a patch with some improvements to Italian labels and some new label definitions .
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1864) New and improved Italian labels
Posted by Bruno Busco <br...@gmail.com>.
Jacques,
a new patch is in jira.
-Bruno
2008/7/7 Jacques Le Roux <ja...@les7arts.com>:
> Bruno,
>
> I'm not sure what you mean : we can't commit as is. I suppose you mean
> ignore this patch, you will provide a new one right ?
>
> Jacques
>
> From: "Bruno Busco" <br...@gmail.com>
>
> Adrian,
>> the thai label changed are due to some setting on my editor I did not
>> managed yet to fix. Please ignore it.
>> Thank you,
>> -Bruno
>>
>> 2008/7/7 Adrian Crum (JIRA) <ji...@apache.org>:
>>
>>
>>> [
>>>
>>> https://issues.apache.org/jira/browse/OFBIZ-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611238#action_12611238
>>> ]
>>>
>>> Adrian Crum commented on OFBIZ-1864:
>>> ------------------------------------
>>>
>>> Bruno,
>>>
>>> A couple of things I noticed in your patch:
>>>
>>> 1. Thai labels are changed. Was that intentional?
>>> 2. Some of your "improved" labels only change upper case letters to lower
>>> case letters. I believe the "de facto" best practice for field labels is
>>> to
>>> capitalize each word. Sentences would have only the first word
>>> capitalized,
>>> of course.
>>>
>>>
>>> > New and improved Italian labels
>>> > -------------------------------
>>> >
>>> > Key: OFBIZ-1864
>>> > URL: https://issues.apache.org/jira/browse/OFBIZ-1864
>>> > Project: OFBiz
>>> > Issue Type: Improvement
>>> > Components: ALL COMPONENTS
>>> > Affects Versions: SVN trunk
>>> > Reporter: Bruno Busco
>>> > Priority: Minor
>>> > Attachments: italian_labels.patch
>>> >
>>> >
>>> > Please find attached a patch with some improvements to Italian labels
>>> and
>>> some new label definitions .
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>>
>>
>
Re: [jira] Commented: (OFBIZ-1864) New and improved Italian labels
Posted by Jacques Le Roux <ja...@les7arts.com>.
Bruno,
I'm not sure what you mean : we can't commit as is. I suppose you mean ignore this patch, you will provide a new one right ?
Jacques
From: "Bruno Busco" <br...@gmail.com>
> Adrian,
> the thai label changed are due to some setting on my editor I did not
> managed yet to fix. Please ignore it.
> Thank you,
> -Bruno
>
> 2008/7/7 Adrian Crum (JIRA) <ji...@apache.org>:
>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611238#action_12611238]
>>
>> Adrian Crum commented on OFBIZ-1864:
>> ------------------------------------
>>
>> Bruno,
>>
>> A couple of things I noticed in your patch:
>>
>> 1. Thai labels are changed. Was that intentional?
>> 2. Some of your "improved" labels only change upper case letters to lower
>> case letters. I believe the "de facto" best practice for field labels is to
>> capitalize each word. Sentences would have only the first word capitalized,
>> of course.
>>
>>
>> > New and improved Italian labels
>> > -------------------------------
>> >
>> > Key: OFBIZ-1864
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-1864
>> > Project: OFBiz
>> > Issue Type: Improvement
>> > Components: ALL COMPONENTS
>> > Affects Versions: SVN trunk
>> > Reporter: Bruno Busco
>> > Priority: Minor
>> > Attachments: italian_labels.patch
>> >
>> >
>> > Please find attached a patch with some improvements to Italian labels and
>> some new label definitions .
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Re: [jira] Commented: (OFBIZ-1864) New and improved Italian labels
Posted by Bruno Busco <br...@gmail.com>.
Adrian,
the thai label changed are due to some setting on my editor I did not
managed yet to fix. Please ignore it.
Thank you,
-Bruno
2008/7/7 Adrian Crum (JIRA) <ji...@apache.org>:
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611238#action_12611238]
>
> Adrian Crum commented on OFBIZ-1864:
> ------------------------------------
>
> Bruno,
>
> A couple of things I noticed in your patch:
>
> 1. Thai labels are changed. Was that intentional?
> 2. Some of your "improved" labels only change upper case letters to lower
> case letters. I believe the "de facto" best practice for field labels is to
> capitalize each word. Sentences would have only the first word capitalized,
> of course.
>
>
> > New and improved Italian labels
> > -------------------------------
> >
> > Key: OFBIZ-1864
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1864
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: ALL COMPONENTS
> > Affects Versions: SVN trunk
> > Reporter: Bruno Busco
> > Priority: Minor
> > Attachments: italian_labels.patch
> >
> >
> > Please find attached a patch with some improvements to Italian labels and
> some new label definitions .
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>