You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mb...@apache.org on 2026/09/09 19:15:57 UTC
(asterixdb) branch master updated (9845ffd9f1 -> f433dda625)
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
from 9845ffd9f1 [ASTERIXDB-3821][STO] Release pages held by exhausted sample cursors
new 5867ee4888 [NO ISSUE][STO] Drop unused upsert output frame
new b5ffcf5a2a Merge branch 'gerrit/trinity' into 'gerrit/morpheus'
new b9b7d699be Merge branch 'gerrit/morpheus' into 'master'
new f433dda625 Merge "Merge branch 'gerrit/morpheus' into 'master'"
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java | 1 -
1 file changed, 1 deletion(-)
(asterixdb) 02/04: Merge branch 'gerrit/trinity' into 'gerrit/morpheus'
Posted by mb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit b5ffcf5a2a396efd2905a1f685fae8e9eebd834a
Merge: 022c6ca1b0 5867ee4888
Author: Michael Blow <mi...@couchbase.com>
AuthorDate: Sat Sep 5 08:02:31 2026 -0400
Merge branch 'gerrit/trinity' into 'gerrit/morpheus'
* [NO ISSUE][STO] Drop unused upsert output frame (MB-73636)
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Change-Id: I95c22132d6e3d92ea11691db47527be1f1aaa7d3
Ext-ref: MB-73636
.../asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java | 1 -
1 file changed, 1 deletion(-)
(asterixdb) 03/04: Merge branch 'gerrit/morpheus' into 'master'
Posted by mb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit b9b7d699beb085ebf94e749c190251255e03f71c
Merge: 9fa48e6ba0 b5ffcf5a2a
Author: Michael Blow <mi...@couchbase.com>
AuthorDate: Sat Sep 5 13:45:42 2026 -0400
Merge branch 'gerrit/morpheus' into 'master'
* [NO ISSUE][STO] Drop unused upsert output frame (MB-73636)
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Change-Id: I7ea498c766f8fcaa578ee2f8e48de0a0667d2c42
Ext-ref: MB-73636
.../asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java | 1 -
1 file changed, 1 deletion(-)
diff --cc asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
index dbb7266883,008caa8e01..8b82c60e30
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
@@@ -295,10 -244,14 +295,9 @@@ public class LSMPrimaryUpsertOperatorNo
@Override
public void open() throws HyracksDataException {
accessor = new FrameTupleAccessor(inputRecDesc);
- writeBuffer = ctx.allocateVSizeFrame();
writer.open();
- indexHelper.open();
- index = indexHelper.getIndexInstance();
+ writerOpen = true;
try {
- if (ctx.getSharedObject() != null) {
- PrimaryIndexLogMarkerCallback callback = new PrimaryIndexLogMarkerCallback((AbstractLSMIndex) index);
- TaskUtil.put(ILogMarkerCallback.KEY_MARKER_CALLBACK, callback, ctx);
- }
missingTupleBuilder = new ArrayTupleBuilder(1);
DataOutput out = missingTupleBuilder.getDataOutput();
try {
(asterixdb) 04/04: Merge "Merge branch 'gerrit/morpheus' into 'master'"
Posted by mb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit f433dda62582ec5d9a901b0587e4e08753553b29
Merge: 9845ffd9f1 b9b7d699be
Author: Apache AsterixDB Gerrit <de...@asterixdb.apache.org>
AuthorDate: Sat Sep 5 19:52:44 2026 +0000
Merge "Merge branch 'gerrit/morpheus' into 'master'"
.../asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java | 1 -
1 file changed, 1 deletion(-)
(asterixdb) 01/04: [NO ISSUE][STO] Drop unused upsert output frame
Posted by mb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git
commit 5867ee48886b0e597714c91f3c9ef68e3a6806d6
Author: Michael Blow <mi...@couchbase.com>
AuthorDate: Sun Aug 23 09:14:47 2026 -0400
[NO ISSUE][STO] Drop unused upsert output frame
- user model changes: no
- storage format changes: no
- interface changes: no
details:
- LSMPrimaryUpsertOperatorNodePushable.open() allocates a frame into the
inherited writeBuffer field and never reads it. The class overrides
open(), nextFrame(), close(), fail() and flush() without calling
super, so the inherited implementations which do read it never run,
and it has no subclasses.
- The frame is compiler.framesize, 32KB by default, and one is held per
dataset per storage partition for the life of the pipeline; nothing
releases it, as FrameManager.deallocateFrames is a no-op.
- A heap dump from an ingestion of 5000 collections over 8 io devices
held 40000 of these operators and 120096 frames of exactly 32768
bytes; this allocation accounted for 40000 of them, 1.25GB of a 9216MB
heap.
- Rebased onto the VSizeFrame allocation extension, which rewrote the
allocation as ctx.allocateVSizeFrame() and so conflicted here. That
routes it through the joblet's accounting, which a frame nothing reads
now also charges against.
Ext-ref: MB-73636
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Change-Id: Iadf1f560a4d541df2c79e0a377d05203aa8dbf2f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21605
Reviewed-by: Michael Blow <mb...@apache.org>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@apache.org>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
.../asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java | 1 -
1 file changed, 1 deletion(-)
diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
index f483a31c4a..008caa8e01 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
@@ -244,7 +244,6 @@ public class LSMPrimaryUpsertOperatorNodePushable extends LSMIndexInsertUpdateDe
@Override
public void open() throws HyracksDataException {
accessor = new FrameTupleAccessor(inputRecDesc);
- writeBuffer = ctx.allocateVSizeFrame();
writer.open();
indexHelper.open();
index = indexHelper.getIndexInstance();