You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/06/10 19:24:51 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1040: SAMZA-2199: [Scala cleanup] Convert MetricsConfig to Java

rmatharu commented on a change in pull request #1040: SAMZA-2199: [Scala cleanup] Convert MetricsConfig to Java
URL: https://github.com/apache/samza/pull/1040#discussion_r292154534
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/util/DiagnosticsUtil.java
 ##########
 @@ -122,6 +122,8 @@ public MetadataFileContents(String version, String metricsSnapshot) {
       DiagnosticsManager diagnosticsManager = new DiagnosticsManager(jobName, jobId, containerId, execEnvContainerId.orElse(""), taskClassVersion,
           samzaVersion, hostName, diagnosticsSystemStream, systemProducer, Duration.ofMillis(new TaskConfig(config).getShutdownMs()));
 
+      Option<String> blacklist = ScalaJavaUtil.JavaOptionals$.MODULE$.toRichOptional(
 
 Review comment:
   This can just be 
   ScalaJavaUtil.JavaOptionals.toRichOptional(metricsConfig.getMetricsSnapshotReporterBlacklist(diagnosticsReporterName)).toOption()
   right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services