You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Yanwen Lin <ly...@gmail.com> on 2021/08/19 05:30:18 UTC

Failed Unit testings in ReassignPartitionsIntegrationTest

Hi folks,

I just joined Kafka community. I would like to work on a beginner issue but get blocked on running unit testings:
I found that I have issue with running the following two unit testings even w/ a fresh git clone of the Kafka repo on trunk branch:
ReassignPartitionsIntegrationTest. testReassignment() => I never passed this test
ReassignPartitionsIntegrationTest. testReassignmentWithAlterIsrDisabled() ==> This is a flaky test, sometimes I can pass but sometimes not.
I ran the following Gradle command:

$./gradlew core:test --tests ReassignPartitionsIntegrationTest

My Java version is:
$ java -version
java version "1.8.0_172-ea"
Java(TM) SE Runtime Environment (build 1.8.0_172-ea-b03)
Java HotSpot(TM) 64-Bit Server VM (build 25.172-b03, mixed mode)

My Scala version is:
$ scala -version
Scala code runner version 2.13.1 -- Copyright 2002-2019, LAMP/EPFL and Lightbend, Inc.

I did a search in the Jira tickets and there is only one I found related to this issue: https://issues.apache.org/jira/browse/KAFKA-12933 <https://issues.apache.org/jira/browse/KAFKA-12933>.

Does anyone encounter this issue before? Thanks!

Best,
Yanwen

Re: Failed Unit testings in ReassignPartitionsIntegrationTest

Posted by David Mao <dm...@confluent.io.INVALID>.

This assertion doesn't seem safe. I opened a PR for a fix. Do you mind
taking a look, Luke?

David

On Thu, Aug 19, 2021 at 12:29 AM Yanwen Lin <ly...@gmail.com> wrote:

> Hi Luke,
>
> Thanks for your suggestion! I will try to test in in VM/Docker.
>
> BTW, may I know the exact java/scala version used in your local env (e.g.
> jdk1.8.0_172 / Scala 2.13.1)? Just would like to rule out this factor.
>
> Best,
> Yanwen
>
>
> > On Aug 18, 2021, at 11:35 PM, Luke Chen <sh...@gmail.com> wrote:
> >
> > Hi Yanwen,
> >
> > Welcome to Kafka!
> > Usually, we posted flaky tests on JIRA when we saw failed tests on
> Jenkins build, either on trunk build, or PR build.
> > What you mentioned 2 (flaky) failed tests have not failed in Jenkins for
> a long time (since build # 364, check below link). Besides, it also passed
> in my local environment. So, it should be the issue in your environment.
> >
> > history for ReassignPartitionsIntegrationTest on jenkins:
> https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/413/testReport/kafka.admin/ReassignPartitionsIntegrationTest/history/
> <
> https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/413/testReport/kafka.admin/ReassignPartitionsIntegrationTest/history/
> >
> >
> >
> > I don't know what suggestion I can provide, since it looks like you can
> compile it successfully, and run tests successfully (mostly).
> > Do you have another environment to test? VM? Docker container?
> >
> > I can have a quick con-call with you to see what might be wrong in your
> env if you want. Just let me know.
> >
> > Thank you.
> > Luke
> >
> > On Thu, Aug 19, 2021 at 1:30 PM Yanwen Lin <lyw1124278064@gmail.com
> <ma...@gmail.com>> wrote:
> > Hi folks,
> >
> > I just joined Kafka community. I would like to work on a beginner issue
> but get blocked on running unit testings:
> > I found that I have issue with running the following two unit testings
> even w/ a fresh git clone of the Kafka repo on trunk branch:
> > ReassignPartitionsIntegrationTest. testReassignment() => I never passed
> this test
> > ReassignPartitionsIntegrationTest.
> testReassignmentWithAlterIsrDisabled() ==> This is a flaky test, sometimes
> I can pass but sometimes not.
> > I ran the following Gradle command:
> >
> > $./gradlew core:test --tests ReassignPartitionsIntegrationTest
> >
> > My Java version is:
> > $ java -version
> > java version "1.8.0_172-ea"
> > Java(TM) SE Runtime Environment (build 1.8.0_172-ea-b03)
> > Java HotSpot(TM) 64-Bit Server VM (build 25.172-b03, mixed mode)
> >
> > My Scala version is:
> > $ scala -version
> > Scala code runner version 2.13.1 -- Copyright 2002-2019, LAMP/EPFL and
> Lightbend, Inc.
> >
> > I did a search in the Jira tickets and there is only one I found related
> to this issue: https://issues.apache.org/jira/browse/KAFKA-12933 <
> https://issues.apache.org/jira/browse/KAFKA-12933> <
> https://issues.apache.org/jira/browse/KAFKA-12933 <
> https://issues.apache.org/jira/browse/KAFKA-12933>>.
> >
> > Does anyone encounter this issue before? Thanks!
> >
> > Best,
> > Yanwen
>
>

Re: Failed Unit testings in ReassignPartitionsIntegrationTest

Posted by Yanwen Lin <ly...@gmail.com>.

Hi Luke,

Thanks for your suggestion! I will try to test in in VM/Docker. 

BTW, may I know the exact java/scala version used in your local env (e.g. jdk1.8.0_172 / Scala 2.13.1)? Just would like to rule out this factor.

Best,
Yanwen


> On Aug 18, 2021, at 11:35 PM, Luke Chen <sh...@gmail.com> wrote:
> 
> Hi Yanwen,
> 
> Welcome to Kafka! 
> Usually, we posted flaky tests on JIRA when we saw failed tests on Jenkins build, either on trunk build, or PR build.
> What you mentioned 2 (flaky) failed tests have not failed in Jenkins for a long time (since build # 364, check below link). Besides, it also passed in my local environment. So, it should be the issue in your environment.
> 
> history for ReassignPartitionsIntegrationTest on jenkins: https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/413/testReport/kafka.admin/ReassignPartitionsIntegrationTest/history/ <https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/413/testReport/kafka.admin/ReassignPartitionsIntegrationTest/history/>
> 
> 
> I don't know what suggestion I can provide, since it looks like you can compile it successfully, and run tests successfully (mostly).
> Do you have another environment to test? VM? Docker container?
> 
> I can have a quick con-call with you to see what might be wrong in your env if you want. Just let me know.
> 
> Thank you.
> Luke
> 
> On Thu, Aug 19, 2021 at 1:30 PM Yanwen Lin <lyw1124278064@gmail.com <ma...@gmail.com>> wrote:
> Hi folks,
> 
> I just joined Kafka community. I would like to work on a beginner issue but get blocked on running unit testings:
> I found that I have issue with running the following two unit testings even w/ a fresh git clone of the Kafka repo on trunk branch:
> ReassignPartitionsIntegrationTest. testReassignment() => I never passed this test
> ReassignPartitionsIntegrationTest. testReassignmentWithAlterIsrDisabled() ==> This is a flaky test, sometimes I can pass but sometimes not.
> I ran the following Gradle command:
> 
> $./gradlew core:test --tests ReassignPartitionsIntegrationTest
> 
> My Java version is:
> $ java -version
> java version "1.8.0_172-ea"
> Java(TM) SE Runtime Environment (build 1.8.0_172-ea-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 25.172-b03, mixed mode)
> 
> My Scala version is:
> $ scala -version
> Scala code runner version 2.13.1 -- Copyright 2002-2019, LAMP/EPFL and Lightbend, Inc.
> 
> I did a search in the Jira tickets and there is only one I found related to this issue: https://issues.apache.org/jira/browse/KAFKA-12933 <https://issues.apache.org/jira/browse/KAFKA-12933> <https://issues.apache.org/jira/browse/KAFKA-12933 <https://issues.apache.org/jira/browse/KAFKA-12933>>.
> 
> Does anyone encounter this issue before? Thanks!
> 
> Best,
> Yanwen

Re: Failed Unit testings in ReassignPartitionsIntegrationTest

Posted by Luke Chen <sh...@gmail.com>.

Hi Yanwen,

Welcome to Kafka!
Usually, we posted flaky tests on JIRA when we saw failed tests on Jenkins
build, either on trunk build, or PR build.
What you mentioned 2 (flaky) failed tests have not failed in Jenkins for a
long time (since build # 364, check below link). Besides, it also passed in
my local environment. So, it should be the issue in your environment.

history for ReassignPartitionsIntegrationTest on jenkins:
https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/413/testReport/kafka.admin/ReassignPartitionsIntegrationTest/history/
[image: 圖片.png]

I don't know what suggestion I can provide, since it looks like you can
compile it successfully, and run tests successfully (mostly).
Do you have another environment to test? VM? Docker container?

I can have a quick con-call with you to see what might be wrong in your env
if you want. Just let me know.

Thank you.
Luke

On Thu, Aug 19, 2021 at 1:30 PM Yanwen Lin <ly...@gmail.com> wrote:

> Hi folks,
>
> I just joined Kafka community. I would like to work on a beginner issue
> but get blocked on running unit testings:
> I found that I have issue with running the following two unit testings
> even w/ a fresh git clone of the Kafka repo on trunk branch:
> ReassignPartitionsIntegrationTest. testReassignment() => I never passed
> this test
> ReassignPartitionsIntegrationTest. testReassignmentWithAlterIsrDisabled()
> ==> This is a flaky test, sometimes I can pass but sometimes not.
> I ran the following Gradle command:
>
> $./gradlew core:test --tests ReassignPartitionsIntegrationTest
>
> My Java version is:
> $ java -version
> java version "1.8.0_172-ea"
> Java(TM) SE Runtime Environment (build 1.8.0_172-ea-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 25.172-b03, mixed mode)
>
> My Scala version is:
> $ scala -version
> Scala code runner version 2.13.1 -- Copyright 2002-2019, LAMP/EPFL and
> Lightbend, Inc.
>
> I did a search in the Jira tickets and there is only one I found related
> to this issue: https://issues.apache.org/jira/browse/KAFKA-12933 <
> https://issues.apache.org/jira/browse/KAFKA-12933>.
>
> Does anyone encounter this issue before? Thanks!
>
> Best,
> Yanwen