You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/16 02:21:54 UTC

[GitHub] [skywalking-client-js] tianyk commented on a change in pull request #45: add `noTraceOrigins` option

tianyk commented on a change in pull request #45:
URL: https://github.com/apache/skywalking-client-js/pull/45#discussion_r594815452



##########
File path: src/trace/segment.ts
##########
@@ -48,8 +48,8 @@ export default function traceSegment(options: CustomOptionsType) {
       url = new URL(window.location.href);
       url.pathname = config[1];
     }
-    if (Array.isArray(options.originAllowList)) {
-      const traced = options.originAllowList.some((rule) => {
+    if (Array.isArray(options.noTraceOrigins)) {

Review comment:
       👌




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org