You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by di...@apache.org on 2005/07/13 20:05:04 UTC
svn commit: r216199 -
/webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
Author: dims
Date: Wed Jul 13 11:05:02 2005
New Revision: 216199
URL: http://svn.apache.org/viewcvs?rev=216199&view=rev
Log:
let's see if trim fixes the problems.
Modified:
webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
Modified: webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
URL: http://svn.apache.org/viewcvs/webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java?rev=216199&r1=216198&r2=216199&view=diff
==============================================================================
--- webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java (original)
+++ webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java Wed Jul 13 11:05:02 2005
@@ -38,8 +38,8 @@
*/
public OMProcessingInstructionImpl(OMContainer parentNode, String target, String value) {
super(parentNode);
- this.target = target;
- this.value = value;
+ this.target = (target == null) ? null : target.trim();
+ this.value = (value == null) ? null : value.trim();
nodeType = OMNode.PI_NODE;
}
Re: [Axis2] Fixing symptom
Posted by Aleksander Slominski <as...@cs.indiana.edu>.
hi,
a little test case will be a big help to get this flagged in future (in
unit test) - please post to stax_builders.
thanks,
alek
Glen Daniels wrote:
> I think you were right earlier, dims, and this is a bug in the BEA
> StAX parser. According to my reading of the specs (XML and StAX), the
> "data" portion of a PI should start *after* the space and not with it.
>
> This works fine with the Codehaus StAX implementation. We should
> report this to BEA.
>
> --G
>
> Davanum Srinivas wrote:
>
>> Can one of you who report this problem, please debug why this is
>> needed? I can't recreate the problem. (glen reports that this indeed
>> fixes the problem, but we need to find out the reason).
>>
>> -- dims
>>
>> On 7/13/05, dims@apache.org <di...@apache.org> wrote:
>>
>>> Author: dims
>>> Date: Wed Jul 13 11:05:02 2005
>>> New Revision: 216199
>>>
>>> URL: http://svn.apache.org/viewcvs?rev=216199&view=rev
>>> Log:
>>> let's see if trim fixes the problems.
>>>
>>> Modified:
>>>
>>> webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>>>
>>>
>>> Modified:
>>> webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>>>
>>> URL:
>>> http://svn.apache.org/viewcvs/webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java?rev=216199&r1=216198&r2=216199&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>>> (original)
>>> +++
>>> webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>>> Wed Jul 13 11:05:02 2005
>>> @@ -38,8 +38,8 @@
>>> */
>>> public OMProcessingInstructionImpl(OMContainer parentNode,
>>> String target, String value) {
>>> super(parentNode);
>>> - this.target = target;
>>> - this.value = value;
>>> + this.target = (target == null) ? null : target.trim();
>>> + this.value = (value == null) ? null : value.trim();
>>> nodeType = OMNode.PI_NODE;
>>> }
>>>
>>>
>>>
>>>
>>
>>
>>
--
The best way to predict the future is to invent it - Alan Kay
Re: [Axis2] Fixing symptom
Posted by Glen Daniels <gl...@thoughtcraft.com>.
I think you were right earlier, dims, and this is a bug in the BEA StAX
parser. According to my reading of the specs (XML and StAX), the "data"
portion of a PI should start *after* the space and not with it.
This works fine with the Codehaus StAX implementation. We should report
this to BEA.
--G
Davanum Srinivas wrote:
> Can one of you who report this problem, please debug why this is
> needed? I can't recreate the problem. (glen reports that this indeed
> fixes the problem, but we need to find out the reason).
>
> -- dims
>
> On 7/13/05, dims@apache.org <di...@apache.org> wrote:
>
>>Author: dims
>>Date: Wed Jul 13 11:05:02 2005
>>New Revision: 216199
>>
>>URL: http://svn.apache.org/viewcvs?rev=216199&view=rev
>>Log:
>>let's see if trim fixes the problems.
>>
>>Modified:
>> webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>>
>>Modified: webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>>URL: http://svn.apache.org/viewcvs/webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java?rev=216199&r1=216198&r2=216199&view=diff
>>==============================================================================
>>--- webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java (original)
>>+++ webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java Wed Jul 13 11:05:02 2005
>>@@ -38,8 +38,8 @@
>> */
>> public OMProcessingInstructionImpl(OMContainer parentNode, String target, String value) {
>> super(parentNode);
>>- this.target = target;
>>- this.value = value;
>>+ this.target = (target == null) ? null : target.trim();
>>+ this.value = (value == null) ? null : value.trim();
>> nodeType = OMNode.PI_NODE;
>> }
>>
>>
>>
>>
>
>
>
[Axis2] Fixing symptom
Posted by Davanum Srinivas <da...@gmail.com>.
Can one of you who report this problem, please debug why this is
needed? I can't recreate the problem. (glen reports that this indeed
fixes the problem, but we need to find out the reason).
-- dims
On 7/13/05, dims@apache.org <di...@apache.org> wrote:
> Author: dims
> Date: Wed Jul 13 11:05:02 2005
> New Revision: 216199
>
> URL: http://svn.apache.org/viewcvs?rev=216199&view=rev
> Log:
> let's see if trim fixes the problems.
>
> Modified:
> webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>
> Modified: webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
> URL: http://svn.apache.org/viewcvs/webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java?rev=216199&r1=216198&r2=216199&view=diff
> ==============================================================================
> --- webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java (original)
> +++ webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java Wed Jul 13 11:05:02 2005
> @@ -38,8 +38,8 @@
> */
> public OMProcessingInstructionImpl(OMContainer parentNode, String target, String value) {
> super(parentNode);
> - this.target = target;
> - this.value = value;
> + this.target = (target == null) ? null : target.trim();
> + this.value = (value == null) ? null : value.trim();
> nodeType = OMNode.PI_NODE;
> }
>
>
>
>
--
Davanum Srinivas -http://blogs.cocoondev.org/dims/
[Axis2] Fixing symptom
Posted by Davanum Srinivas <da...@gmail.com>.
Can one of you who report this problem, please debug why this is
needed? I can't recreate the problem. (glen reports that this indeed
fixes the problem, but we need to find out the reason).
-- dims
On 7/13/05, dims@apache.org <di...@apache.org> wrote:
> Author: dims
> Date: Wed Jul 13 11:05:02 2005
> New Revision: 216199
>
> URL: http://svn.apache.org/viewcvs?rev=216199&view=rev
> Log:
> let's see if trim fixes the problems.
>
> Modified:
> webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
>
> Modified: webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java
> URL: http://svn.apache.org/viewcvs/webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java?rev=216199&r1=216198&r2=216199&view=diff
> ==============================================================================
> --- webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java (original)
> +++ webservices/axis/trunk/java/modules/xml/src/org/apache/axis2/om/impl/llom/OMProcessingInstructionImpl.java Wed Jul 13 11:05:02 2005
> @@ -38,8 +38,8 @@
> */
> public OMProcessingInstructionImpl(OMContainer parentNode, String target, String value) {
> super(parentNode);
> - this.target = target;
> - this.value = value;
> + this.target = (target == null) ? null : target.trim();
> + this.value = (value == null) ? null : value.trim();
> nodeType = OMNode.PI_NODE;
> }
>
>
>
>
--
Davanum Srinivas -http://blogs.cocoondev.org/dims/