[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2375: IGNITE-20076 Improve networking shutdown implementation

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #2375:
URL: https://github.com/apache/ignite-3/pull/2375#discussion_r1277499069


##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryServerHandshakeManager.java:
##########
@@ -177,12 +182,20 @@ public void onMessage(NetworkMessage message) {
         if (message instanceof HandshakeRejectedMessage) {
             HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
 
-            LOG.warn("Handshake rejected by client: {}", msg.reason());
+            boolean ignorable = stopping.get() || !msg.critical();

Review Comment:
   Why do we check the stopping flag here?



##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryClientHandshakeManager.java:
##########
@@ -156,12 +161,20 @@ public void onMessage(NetworkMessage message) {
         if (message instanceof HandshakeRejectedMessage) {
             HandshakeRejectedMessage msg = (HandshakeRejectedMessage) message;
 
-            LOG.warn("Handshake rejected by server: {}", msg.reason());
+            boolean ignorable = stopping.get() || !msg.critical();

Review Comment:
   Same question



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org