[GitHub] [pinot] walterddr commented on a diff in pull request #10991: [enhance]: When enable case-insensitive, don't allow to add newly col…

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1245949367


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -359,7 +359,8 @@ private void validateSchemaInternal(Schema schema) {
     validateSchemaName(schema.getSchemaName());
     try {
       List<TableConfig> tableConfigs = _pinotHelixResourceManager.getTableConfigsForSchema(schema.getSchemaName());
-      SchemaUtils.validate(schema, tableConfigs);
+      boolean isIgnoreCase = _pinotHelixResourceManager.isIgnoreCase();
+      SchemaUtils.validate(schema, tableConfigs, isIgnoreCase);

Review Comment:
   i wonder if this is even necessary to extract this from helix resource manager. eventually this is a startup time config 
   ```
   Boolean.parseBoolean(configs.getOrDefault(Helix.ENABLE_CASE_INSENSITIVE_KEY,
               Boolean.toString(Helix.DEFAULT_ENABLE_CASE_INSENSITIVE)));
   ```
   we can simply encapsulate in the broker/controller starter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org