You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/09 06:41:46 UTC
[jira] [Commented] (FLUME-1164) Reconsider whether configure()
should be called on the same component object after a reconfig event
[ https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271082#comment-13271082 ]
jiraposter@reviews.apache.org commented on FLUME-1164:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4939/#review7719
-----------------------------------------------------------
Ship it!
+1
Please rebase the patch and attach it to the Jira.
- Arvind
On 2012-04-30 21:33:09, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4939/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-30 21:33:09)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components.
bq.
bq.
bq. This addresses bug FLUME-1164.
bq. https://issues.apache.org/jira/browse/FLUME-1164
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java c6ae2f5
bq. flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 07c3d0b
bq. flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
bq.
bq. Diff: https://reviews.apache.org/r/4939/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Reconsider whether configure() should be called on the same component object after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
> After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira