You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/08/27 12:12:16 UTC
[GitHub] [tinkerpop] spmallette opened a new pull request #1317: TINKERPOP-2335 Set node.js support at 10 for 3.5.0
spmallette opened a new pull request #1317:
URL: https://github.com/apache/tinkerpop/pull/1317
https://issues.apache.org/jira/browse/TINKERPOP-2335
Upgraded frontend plugin and centralized configuration a bit.
Builds with `mvn clean install`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1317: TINKERPOP-2335 Set node.js support at 10 for 3.5.0
Posted by GitBox <gi...@apache.org>.
jorgebay commented on a change in pull request #1317:
URL: https://github.com/apache/tinkerpop/pull/1317#discussion_r478371429
##########
File path: gremlin-javascript/pom.xml
##########
@@ -29,10 +29,21 @@ limitations under the License.
<maven.test.skip>false</maven.test.skip>
<skipTests>${maven.test.skip}</skipTests>
<gremlin.server.dir>${project.parent.basedir}/gremlin-server</gremlin.server.dir>
+ <npm.version>6.14.6</npm.version>
+ <node.version>v10.22.0</node.version>
Review comment:
Good idea to extract it into a property.
##########
File path: gremlin-javascript/src/main/javascript/gremlin-javascript/package.json
##########
@@ -40,4 +40,4 @@
"engines": {
"node": ">=6"
Review comment:
We should state `"node": ">= 10"` in the package.json
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1317: TINKERPOP-2335 Set node.js support at 10 for 3.5.0
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1317:
URL: https://github.com/apache/tinkerpop/pull/1317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a change in pull request #1317: TINKERPOP-2335 Set node.js support at 10 for 3.5.0
Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1317:
URL: https://github.com/apache/tinkerpop/pull/1317#discussion_r478375168
##########
File path: gremlin-javascript/src/main/javascript/gremlin-javascript/package.json
##########
@@ -40,4 +40,4 @@
"engines": {
"node": ">=6"
Review comment:
oops - shouldn't have missed that - fixed now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org