[GitHub] rafaelweingartner commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2370: CLOUDSTACK-9595: Fix regression introduced in #1762
URL: https://github.com/apache/cloudstack/pull/2370#discussion_r157983028
 
 

 ##########
 File path: server/src/com/cloud/network/IpAddressManagerImpl.java
 ##########
 @@ -936,8 +942,8 @@ public PublicIp assignDedicateIpAddress(Account owner, final Long guestNtwkId, f
                 displayIp = vpc.isDisplay();
             }
 
-            return fetchNewPublicIp(dcId, null, null, owner, VlanType.VirtualNetwork, guestNtwkId, isSourceNat, false, null, false, vpcId, displayIp);
-
+            ip = fetchNewPublicIp(dcId, null, null, owner, VlanType.VirtualNetwork, guestNtwkId, isSourceNat, true, null, false, vpcId, displayIp);
 
 Review comment:
   You can return directly the call to `fetchNewPublicIp`.
   
   I have not checked. What is that boolean flag you changed there?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services