You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/17 02:42:48 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #8103: [pulsar-broker] Added support to force deleting tenant

codelipenghui commented on a change in pull request #8103:
URL: https://github.com/apache/pulsar/pull/8103#discussion_r524848532



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTest.java
##########
@@ -455,9 +455,11 @@ public void properties() throws Exception {
             assertEquals(e.getResponse().getStatus(), Status.NOT_FOUND.getStatusCode());
         }
 
+        AsyncResponse response = mock(AsyncResponse.class);
+
         // Check deleting non-existing property
         try {
-            properties.deleteTenant("non-existing");
+            properties.deleteTenant(response, "non-existing", false);

Review comment:
       Is the test related to this change? I think the test should cover there are namespaces and topics under a tenant, then we delete the tenant forcefully should success.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org