You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Daniel Krisher <da...@gmail.com> on 2005/08/16 16:35:49 UTC

assembly-plugin FileSet includes does not match empty directories

I have noticed that any fileset includes specified in the assembly xml will 
not match empty directories, even if the empty directory is explicitly 
included (<include>emptyDir</include>), regardless of the archive type. This 
is not really a big problem, I was curious if this was by design or by 
accident though... A cursory glance at the source leads me to believe that 
this might be happening in the plexus code 
(AbstractArchiver/DirectoryScanner), although the documentation seems to 
indicate that directories are matched (with no mention of empty 
directories).

-- 
Daniel Krisher

Re: assembly-plugin FileSet includes does not match empty directories

Posted by Daniel Krisher <da...@gmail.com>.
That you just opened... :)

On 8/17/05, Daniel Krisher <da...@gmail.com> wrote:
> Ahh, there is still an unresolved JIRA issue:  PLX-148, Added a method
> within AbstractArchiver to include empty directories within the
> archiver.
> 
> On 8/17/05, Edwin Punzalan <ep...@exist.com> wrote:
> > Hi brett,
> >
> > I remember sending a patch to dev@plexus.codehaus.org that added a
> > method to AbstractArchiver to include empty Directories...
> >
> > Included with it is the patch for ZipArchiver that make use of the new
> > method.
> >
> >
> >
> > Brett Porter wrote:
> >
> > >This should probably be a configurable option. Would you mind filing a
> > >jira issue?
> > >
> > >Thanks,
> > >Brett
> > >
> > >On 8/17/05, Daniel Krisher <da...@gmail.com> wrote:
> > >
> > >
> > >>I have noticed that any fileset includes specified in the assembly xml will
> > >>not match empty directories, even if the empty directory is explicitly
> > >>included (<include>emptyDir</include>), regardless of the archive type. This
> > >>is not really a big problem, I was curious if this was by design or by
> > >>accident though... A cursory glance at the source leads me to believe that
> > >>this might be happening in the plexus code
> > >>(AbstractArchiver/DirectoryScanner), although the documentation seems to
> > >>indicate that directories are matched (with no mention of empty
> > >>directories).
> > >>
> > >>--
> > >>Daniel Krisher
> > >>
> > >>
> > >>
> > >>
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > >For additional commands, e-mail: users-help@maven.apache.org
> > >
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
> >
> 
> 
> 
> --
> Daniel Krisher
> 


-- 
Daniel Krisher

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: assembly-plugin FileSet includes does not match empty directories

Posted by Daniel Krisher <da...@gmail.com>.
Ahh, there is still an unresolved JIRA issue:  PLX-148, Added a method
within AbstractArchiver to include empty directories within the
archiver.

On 8/17/05, Edwin Punzalan <ep...@exist.com> wrote:
> Hi brett,
> 
> I remember sending a patch to dev@plexus.codehaus.org that added a
> method to AbstractArchiver to include empty Directories...
> 
> Included with it is the patch for ZipArchiver that make use of the new
> method.
> 
> 
> 
> Brett Porter wrote:
> 
> >This should probably be a configurable option. Would you mind filing a
> >jira issue?
> >
> >Thanks,
> >Brett
> >
> >On 8/17/05, Daniel Krisher <da...@gmail.com> wrote:
> >
> >
> >>I have noticed that any fileset includes specified in the assembly xml will
> >>not match empty directories, even if the empty directory is explicitly
> >>included (<include>emptyDir</include>), regardless of the archive type. This
> >>is not really a big problem, I was curious if this was by design or by
> >>accident though... A cursory glance at the source leads me to believe that
> >>this might be happening in the plexus code
> >>(AbstractArchiver/DirectoryScanner), although the documentation seems to
> >>indicate that directories are matched (with no mention of empty
> >>directories).
> >>
> >>--
> >>Daniel Krisher
> >>
> >>
> >>
> >>
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> >For additional commands, e-mail: users-help@maven.apache.org
> >
> >
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
> 
> 



-- 
Daniel Krisher

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: assembly-plugin FileSet includes does not match empty directories

Posted by Edwin Punzalan <ep...@exist.com>.
Hi brett,

I remember sending a patch to dev@plexus.codehaus.org that added a 
method to AbstractArchiver to include empty Directories...

Included with it is the patch for ZipArchiver that make use of the new 
method.



Brett Porter wrote:

>This should probably be a configurable option. Would you mind filing a
>jira issue?
>
>Thanks,
>Brett
>
>On 8/17/05, Daniel Krisher <da...@gmail.com> wrote:
>  
>
>>I have noticed that any fileset includes specified in the assembly xml will
>>not match empty directories, even if the empty directory is explicitly
>>included (<include>emptyDir</include>), regardless of the archive type. This
>>is not really a big problem, I was curious if this was by design or by
>>accident though... A cursory glance at the source leads me to believe that
>>this might be happening in the plexus code
>>(AbstractArchiver/DirectoryScanner), although the documentation seems to
>>indicate that directories are matched (with no mention of empty
>>directories).
>>
>>--
>>Daniel Krisher
>>
>>
>>    
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
>For additional commands, e-mail: users-help@maven.apache.org
>
>
>  
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: assembly-plugin FileSet includes does not match empty directories

Posted by Brett Porter <br...@gmail.com>.
This should probably be a configurable option. Would you mind filing a
jira issue?

Thanks,
Brett

On 8/17/05, Daniel Krisher <da...@gmail.com> wrote:
> I have noticed that any fileset includes specified in the assembly xml will
> not match empty directories, even if the empty directory is explicitly
> included (<include>emptyDir</include>), regardless of the archive type. This
> is not really a big problem, I was curious if this was by design or by
> accident though... A cursory glance at the source leads me to believe that
> this might be happening in the plexus code
> (AbstractArchiver/DirectoryScanner), although the documentation seems to
> indicate that directories are matched (with no mention of empty
> directories).
> 
> --
> Daniel Krisher
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org