[GitHub] flink pull request #4507: [FLINK-7404] [table] Generate code for non-equi jo...

[fhueske <gi...@git.apache.org>]

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4507

    [FLINK-7404] [table] Generate code for non-equi join conditions only.

    ## What is the purpose of the change
    
    Generate code only for non-equi join conditions for Table API / SQL batch joins. 
    Equi join conditions are validated by the DataSet API.
    
    ## Brief change log
    
    - remove equi-join conditions before code generation
    
    ## Verifying this change
    
    - all existing tests pass.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): *no*
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: *no*
      - The serializers: *no*
      - The runtime per-record code paths (performance sensitive): *yes*
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: *no*
    
    ## Documentation
    
    - internal change only. No documentation required.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableJoinCondition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4507
    
----
commit e1871c4f2e5ee9cc42831469fe6580d25d32361c
Author: Fabian Hueske <fh...@apache.org>
Date:   2017-08-09T15:41:10Z

    [FLINK-7404] [table] Generate code for non-equi join conditions only.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4507: [FLINK-7404] [table] Generate code for non-equi join cond...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4507
  
    Merging


---

[GitHub] flink pull request #4507: [FLINK-7404] [table] Generate code for non-equi jo...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4507


---