Re: [PR] Fix #11856: Improve error message for prefix-based remote repository filtering errors [maven]

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #11888:
URL: https://github.com/apache/maven/pull/11888#discussion_r3267636675


##########
impl/maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java:
##########
@@ -260,15 +268,43 @@ private String getMessage(String message, Throwable exception) {
                 fullMessage = join(fullMessage, exceptionMessage);
             }
 
+            if (t instanceof ArtifactFilteredOutException) {
+                hasArtifactFilteredOut = true;
+            }
+
             if (!dejaVu.add(t)) {
                 fullMessage = join(fullMessage, "[CIRCULAR REFERENCE]");
                 break;
             }
         }
 
+        if (hasArtifactFilteredOut) {
+            fullMessage += System.lineSeparator()
+                    + System.lineSeparator()
+                    + "This error indicates that the remote repository's prefix file does not list"
+                    + " this artifact's group. This commonly happens with repository managers"
+                    + " using virtual/group repositories that do not properly aggregate prefix files."
+                    + System.lineSeparator()
+                    + "To disable prefix-based filtering, add"
+                    + " -Daether.remoteRepositoryFilter.prefixes=false"
+                    + " to your command line or to .mvn/maven.config."
+                    + System.lineSeparator()
+                    + "See https://maven.apache.org/resolver/remote-repository-filtering.html";

Review Comment:
   _Claude Code on behalf of Guillaume Nodet_
   
   Good point! Updated the error message to mention both `-Daether.remoteRepositoryFilter.prefixes=false` and `-Daether.remoteRepositoryFilter.groupId=false` so users are aware of both filter types. See 58cb40e3cd.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org