[GitHub] [accumulo] keith-turner commented on issue #3668: DatafileManager.importMapFiles question

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on issue #3668:
URL: https://github.com/apache/accumulo/issues/3668#issuecomment-1658658651

   > Does updating the tablet metadata outside of the tablet lock in importMapFiles make it more likely that the compareTabletInfo check would see a file in the tablet metadata but not in datafileSizes?
   
   compareTabletInfo relies not on the tablet lock, but on counters [incremented here](https://github.com/apache/accumulo/blob/e4df61206245cd4b454debfeef2f62973cc4531b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L246) and [incremented here](https://github.com/apache/accumulo/blob/e4df61206245cd4b454debfeef2f62973cc4531b/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L287).
   
   compareTabletInfo does the following.
   
    1. Get a copy of a tablets update counters
    2. Read the tablets metadata
    3. compare metadata read to what tablet has in memory
    4. Get another copy of the tablets update counters
    5. If the counters are exactly the same it knows its check did not overlap in time with an update.  If it did not overlap in time with an update and things differ then it logs a message.
   
   The counter increments must cover the in memory update update and metadata update.  There was a problem where the counter increments were not covering everything that was fixed in #3392. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org