You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/05 20:17:58 UTC
[GitHub] [logging-log4j2] vorburger opened a new pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
vorburger opened a new pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686
See https://issues.apache.org/jira/browse/RAT-294,
and https://github.com/apache/logging-log4j2/pull/653.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007365746
I thought the RAT version was set in the parent POM through a property? I
don't think we want to override it, do we?
Gary
On Thu, Jan 6, 2022, 21:57 Carter Kozak ***@***.***> wrote:
> Merged #686 <https://github.com/apache/logging-log4j2/pull/686> into
> release-2.x.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/logging-log4j2/pull/686#event-5855674383>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJB6NYMTSCZHLTU6277VUDUUZJBZANCNFSM5LKYHA6Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007091452
@carterkozak perhaps you would like to merge this? (It's -about to- have a full green build.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007365746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007387515
It does make perfect sense 😀 but it is not the best solution 😉 . All is well, thank you for pitching in 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak merged pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
carterkozak merged pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007384817
> I thought the RAT version was set in the parent POM through a property? I don't think we want to override it, do we?
This PR does not override it. If you look at the diff, you'll notice that it changes a `0.12` to a `0.13` in some places, and adds `<consoleOutput>true`. (I agree that it does look like some consolidation in the POM may be possible here, but that was not my aim & goal with this PR - I've merely changed what I found existed as-is.) Hope this makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007384817
> I thought the RAT version was set in the parent POM through a property? I don't think we want to override it, do we?
This PR does not override it. If you look at the diff, you'll notice that it changes a `0.12` to a `0.13` in some places, and adds `<consoleOutput>true`. (I agree that it does look like some consolidation in the POM may be possible here, but that was not my aim & goal with this PR - I've merely changed what I found existed as-is.) Hope this makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1007100337
Great find, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vorburger commented on pull request #686: Use apache-rat-plugin's consoleOutput (and upgrade straggler versions)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #686:
URL: https://github.com/apache/logging-log4j2/pull/686#issuecomment-1006052585
This PR will fail to pass the CI build until the current known test failure is fixed, see #685.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org