You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2019/10/15 21:20:00 UTC

[jira] [Commented] (BEAM-8173) Filesystems.matchSingleFileSpec throws away the actual failure exception

    [ https://issues.apache.org/jira/browse/BEAM-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952299#comment-16952299 ] 

Kenneth Knowles commented on BEAM-8173:
---------------------------------------

[~chamikara] FYI filed this as a starter bug in code you may be interested in

> Filesystems.matchSingleFileSpec throws away the actual failure exception
> ------------------------------------------------------------------------
>
>                 Key: BEAM-8173
>                 URL: https://issues.apache.org/jira/browse/BEAM-8173
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: Major
>              Labels: easyfix, starter
>
> At [1] the result of a non-OK match causes an exception to be thrown. But the exception does not include the actual cause of the failure, so it cannot be efficiently debugged. It appears that the design of MatchResult is that it should call metadata() without bothering to check status, so that the underlying exception can be re-raised and caught and put in the chain of causes, as it should be.
> [1] https://github.com/apache/beam/blob/c2f0d282337f3ae0196a7717712396a5a41fdde1/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java#L190



--
This message was sent by Atlassian Jira
(v8.3.4#803005)