You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/11 15:39:43 UTC
[GitHub] rabbah commented on a change in pull request #311: Display
appropriate message for trigger fire when 204 is returned
rabbah commented on a change in pull request #311: Display appropriate message for trigger fire when 204 is returned
URL: https://github.com/apache/incubator-openwhisk-cli/pull/311#discussion_r194450149
##########
File path: commands/trigger.go
##########
@@ -92,13 +93,24 @@ var triggerFireCmd = &cobra.Command{
return werr
}
+ if resp.StatusCode == http.StatusNoContent {
Review comment:
I suggest starting to add go unit tests as well for such changes as it will vector toward better factoring of the code. For example a unit test that mocks an HTTP response and confirms returning the expected message and CLI code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services