You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/18 18:39:25 UTC
[jira] [Commented] (FLINK-3778) ScalaShellRemoteStreamEnvironment
cannot be forwarded a user configuration
[ https://issues.apache.org/jira/browse/FLINK-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245968#comment-15245968 ]
ASF GitHub Bot commented on FLINK-3778:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1906
[FLINK-3778] [shell] Forward configuration from FlinkILoop to ScalaShellRemoteStreamEnvironment
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [X] General
- The pull request references the related JIRA issue
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
With this PR the configuration of the FlinkILoop is properly forwarded to the
ScalaShellRemoteStreamEnvironment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixScalaShellStream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1906.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1906
----
commit 22d710a17003863a347546f248f35a609cbf6c91
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-04-18T16:34:55Z
[FLINK-3778] [shell] Forward configuration from FlinkILoop to ScalaShellRemoteStreamEnvironment
With this PR the configuration of the FlinkILoop is properly forwarded to the
ScalaShellRemoteStreamEnvironment.
----
> ScalaShellRemoteStreamEnvironment cannot be forwarded a user configuration
> --------------------------------------------------------------------------
>
> Key: FLINK-3778
> URL: https://issues.apache.org/jira/browse/FLINK-3778
> Project: Flink
> Issue Type: Improvement
> Components: Scala Shell
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> The {{ScalaShellRemoteStreamEnvironment}} cannot unlike the {{ScalaShellRemoteEnvironment}} be configured with a user configuration. This effectively prohibits an user to connect against an HA cluster. I think it would be good to be able to specify a user configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)