You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/09/11 07:36:25 UTC

[GitHub] rhtyd commented on a change in pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?

rhtyd commented on a change in pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?
URL: https://github.com/apache/cloudstack/pull/2261#discussion_r137998114
 
 

 ##########
 File path: test/integration/smoke/test_iso.py
 ##########
 @@ -320,8 +320,8 @@ def test_02_edit_iso(self):
             "Check display text of updated ISO"
         )
         self.assertEqual(
-            iso_response.bootable,
-            self.services["bootable"],
+            str(iso_response.bootable).lower(),
 
 Review comment:
   I don't have any idea, where/how it may change. LGTM, I think we can merge this and revisit later if needed.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services