You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/12 13:43:12 UTC
[GitHub] [incubator-shenyu] lahmXu opened a new pull request, #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
lahmXu opened a new pull request, #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541
Fix #3484 , task 5 and 7
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] lahmXu commented on pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
lahmXu commented on PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#issuecomment-1153968854
> also check #3542
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895572590
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -170,7 +181,7 @@ private String getPathByAnnotation(@Nullable final Annotation annotation,
}
private String buildApiSuperPath(@NonNull final Class<?> method) {
- ShenyuSpringWebSocketClient webSocketClient = AnnotatedElementUtils.findMergedAnnotation(method, ShenyuSpringWebSocketClient.class);
+ ShenyuSpringWebSocketClient webSocketClient = AnnotationUtils.findAnnotation(method, ShenyuSpringWebSocketClient.class);
Review Comment:
just use `AnnotatedElementUtils#findMergedAnnotation`, check this (PR)[https://github.com/apache/incubator-shenyu/pull/3520].
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -170,7 +181,7 @@ private String getPathByAnnotation(@Nullable final Annotation annotation,
}
private String buildApiSuperPath(@NonNull final Class<?> method) {
- ShenyuSpringWebSocketClient webSocketClient = AnnotatedElementUtils.findMergedAnnotation(method, ShenyuSpringWebSocketClient.class);
+ ShenyuSpringWebSocketClient webSocketClient = AnnotationUtils.findAnnotation(method, ShenyuSpringWebSocketClient.class);
Review Comment:
just use `AnnotatedElementUtils#findMergedAnnotation`, check this (PR)[https://github.com/apache/incubator-shenyu/pull/3520] .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895840416
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -93,9 +93,14 @@ public SpringWebSocketClientBeanPostProcessor(final PropertiesConfig clientConfi
}
@Override
- public Object postProcessAfterInitialization(@NonNull final Object bean,
- @NonNull final String beanName) throws BeansException {
+ public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
+ String[] beanNames = contextRefreshedEvent.getApplicationContext().getBeanDefinitionNames();
Review Comment:
How about use `contextRefreshedEvent.getApplicationContext().getBeansWithAnnotation(ShenyuSpringWebSocketClient.class);` directly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895572590
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -170,7 +181,7 @@ private String getPathByAnnotation(@Nullable final Annotation annotation,
}
private String buildApiSuperPath(@NonNull final Class<?> method) {
- ShenyuSpringWebSocketClient webSocketClient = AnnotatedElementUtils.findMergedAnnotation(method, ShenyuSpringWebSocketClient.class);
+ ShenyuSpringWebSocketClient webSocketClient = AnnotationUtils.findAnnotation(method, ShenyuSpringWebSocketClient.class);
Review Comment:
just use `AnnotatedElementUtils#findMergedAnnotation`, check this [PR](https://github.com/apache/incubator-shenyu/pull/3520) .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895571348
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -88,14 +93,21 @@ public SpringWebSocketClientBeanPostProcessor(final PropertiesConfig clientConfi
}
this.isFull = Boolean.parseBoolean(props.getProperty(ShenyuClientConstants.IS_FULL, Boolean.FALSE.toString()));
mappingAnnotation.add(ShenyuSpringWebSocketClient.class);
+ executorService = Executors.newSingleThreadExecutor(new ThreadFactoryBuilder().setNameFormat("shenyu-websocket-client-thread-pool-%d").build());
publisher.start(shenyuClientRegisterRepository);
}
@Override
- public Object postProcessAfterInitialization(@NonNull final Object bean,
- @NonNull final String beanName) throws BeansException {
+ public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
+ String[] beanNames = contextRefreshedEvent.getApplicationContext().getBeanDefinitionNames();
+ for (String beanName : beanNames) {
+ Object bean = contextRefreshedEvent.getApplicationContext().getBean(beanName);
+ executorService.execute(() -> handler(bean));
Review Comment:
please remove `executorService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895572590
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -170,7 +181,7 @@ private String getPathByAnnotation(@Nullable final Annotation annotation,
}
private String buildApiSuperPath(@NonNull final Class<?> method) {
- ShenyuSpringWebSocketClient webSocketClient = AnnotatedElementUtils.findMergedAnnotation(method, ShenyuSpringWebSocketClient.class);
+ ShenyuSpringWebSocketClient webSocketClient = AnnotationUtils.findAnnotation(method, ShenyuSpringWebSocketClient.class);
Review Comment:
just use `AnnotatedElementUtils#findMergedAnnotation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang merged pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang merged PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r896292777
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -93,9 +93,14 @@ public SpringWebSocketClientBeanPostProcessor(final PropertiesConfig clientConfi
}
@Override
- public Object postProcessAfterInitialization(@NonNull final Object bean,
- @NonNull final String beanName) throws BeansException {
+ public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
+ String[] beanNames = contextRefreshedEvent.getApplicationContext().getBeanDefinitionNames();
Review Comment:
I see and I still recommend `contextRefreshedEvent.getApplicationContext().getBeansWithAnnotation(ShenyuSpringWebSocketClient.class);`, but keep line 107. In this way, most useless beans can be filtered out at the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895571069
##########
shenyu-client/shenyu-client-sofa/src/main/java/org/apache/shenyu/client/sofa/SofaServiceEventListener.java:
##########
@@ -90,11 +92,11 @@ public SofaServiceBeanPostProcessor(final PropertiesConfig clientConfig, final S
}
@Override
- public Object postProcessAfterInitialization(final Object bean, final String beanName) throws BeansException {
- if (bean instanceof ServiceFactoryBean) {
- executorService.execute(() -> handler((ServiceFactoryBean) bean));
+ public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
+ Map<String, ServiceFactoryBean> serviceBean = contextRefreshedEvent.getApplicationContext().getBeansOfType(ServiceFactoryBean.class);
+ for (Map.Entry<String, ServiceFactoryBean> entry : serviceBean.entrySet()) {
+ executorService.execute(() -> handler(entry.getValue()));
Review Comment:
please remove `executorService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895572590
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -170,7 +181,7 @@ private String getPathByAnnotation(@Nullable final Annotation annotation,
}
private String buildApiSuperPath(@NonNull final Class<?> method) {
- ShenyuSpringWebSocketClient webSocketClient = AnnotatedElementUtils.findMergedAnnotation(method, ShenyuSpringWebSocketClient.class);
+ ShenyuSpringWebSocketClient webSocketClient = AnnotationUtils.findAnnotation(method, ShenyuSpringWebSocketClient.class);
Review Comment:
just use `AnnotatedElementUtils#findMergedAnnotation`, check this (PR) [https://github.com/apache/incubator-shenyu/pull/3520] .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] lahmXu commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
lahmXu commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r895900178
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -93,9 +93,14 @@ public SpringWebSocketClientBeanPostProcessor(final PropertiesConfig clientConfi
}
@Override
- public Object postProcessAfterInitialization(@NonNull final Object bean,
- @NonNull final String beanName) throws BeansException {
+ public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
+ String[] beanNames = contextRefreshedEvent.getApplicationContext().getBeanDefinitionNames();
Review Comment:
After testing I found a problem with this. It will not get the bean when @ShenyuSpringWebSocketClient marked on the method.
like this:
```
@Component
public class Config {
@ShenyuSpringWebSocketClient(path = "/org/apache/shenyu/examples/websocket/**", desc = "onlineusers")
public void handle() {
return;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dragon-zhang commented on pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
dragon-zhang commented on PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#issuecomment-1153757479
also check https://github.com/apache/incubator-shenyu/pull/3542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#issuecomment-1153188072
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3541](https://codecov.io/gh/apache/incubator-shenyu/pull/3541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2bf83b) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/b2b5f6f48ae0e9840b795e8e045a65b1f61b0836?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2b5f6f) will **decrease** coverage by `0.31%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3541 +/- ##
============================================
- Coverage 62.83% 62.51% -0.32%
+ Complexity 5571 5541 -30
============================================
Files 842 842
Lines 23351 23351
Branches 2118 2116 -2
============================================
- Hits 14672 14598 -74
- Misses 7331 7400 +69
- Partials 1348 1353 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ter/client/sofa/ShenyuSofaClientConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zb2ZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL2NsaWVudC9zb2ZhL1NoZW55dVNvZmFDbGllbnRDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...cket/ShenyuSpringWebSocketClientConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmctd2Vic29ja2V0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL2NsaWVudC9zcHJpbmcvd2Vic29ja2V0L1NoZW55dVNwcmluZ1dlYlNvY2tldENsaWVudENvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...plugin/logging/rocketmq/LoggingRocketMQPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvTG9nZ2luZ1JvY2tldE1RUGx1Z2luLmphdmE=) | `22.72% <0.00%> (-72.73%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...ogging/rocketmq/body/LoggingServerHttpRequest.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcvcm9ja2V0bXEvYm9keS9Mb2dnaW5nU2VydmVySHR0cFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoV2FycERUTy5qYXZh) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| [...org/apache/shenyu/admin/model/dto/AuthPathDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoRFRPLmphdmE=) | `58.82% <0.00%> (-5.89%)` | :arrow_down: |
| [...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9SZXdyaXRlUGx1Z2luLmphdmE=) | `66.66% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2b5f6f...b2bf83b](https://codecov.io/gh/apache/incubator-shenyu/pull/3541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] lahmXu commented on a diff in pull request #3541: [ISSUE #3484] Fix sofa and websocket client lossless registration.
Posted by GitBox <gi...@apache.org>.
lahmXu commented on code in PR #3541:
URL: https://github.com/apache/incubator-shenyu/pull/3541#discussion_r899185527
##########
shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:
##########
@@ -93,9 +93,14 @@ public SpringWebSocketClientBeanPostProcessor(final PropertiesConfig clientConfi
}
@Override
- public Object postProcessAfterInitialization(@NonNull final Object bean,
- @NonNull final String beanName) throws BeansException {
+ public void onApplicationEvent(final ContextRefreshedEvent contextRefreshedEvent) {
+ String[] beanNames = contextRefreshedEvent.getApplicationContext().getBeanDefinitionNames();
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org