You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by ri...@apache.org on 2006/10/26 16:47:49 UTC

svn commit: r468023 - /incubator/felix/trunk/framework/src/main/java/org/apache/felix/framework/Felix.java

Author: rickhall
Date: Thu Oct 26 07:47:49 2006
New Revision: 468023

URL: http://svn.apache.org/viewvc?view=rev&rev=468023
Log:
A previous change to help garbage collection was causing an NPE. It is
unclear to me that the "fix" is actually necessary, so I am commenting
it out now until we can investigate it further.

Modified:
    incubator/felix/trunk/framework/src/main/java/org/apache/felix/framework/Felix.java

Modified: incubator/felix/trunk/framework/src/main/java/org/apache/felix/framework/Felix.java
URL: http://svn.apache.org/viewvc/incubator/felix/trunk/framework/src/main/java/org/apache/felix/framework/Felix.java?view=diff&rev=468023&r1=468022&r2=468023
==============================================================================
--- incubator/felix/trunk/framework/src/main/java/org/apache/felix/framework/Felix.java (original)
+++ incubator/felix/trunk/framework/src/main/java/org/apache/felix/framework/Felix.java Thu Oct 26 07:47:49 2006
@@ -3152,6 +3152,13 @@
                     // This physically removes the bundle from memory
                     // as well as the bundle cache.
                     garbageCollectBundle(m_bundle);
+// TODO: FRAMEWORK - There is some indication that there is a memory leak
+//                   if we do not null the BundleInfo here. We should verify
+//                   that this is true, because if we null here then we have
+//                   check for nulls when we are releasing bundle locks, which
+//                   maybe cascading unnecessary ugliness. For now, I will
+//                   leave this commented out until we can investigate further.
+//                    m_bundle.setInfo(null);
                     m_bundle = null;
                 }
                 else