You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/30 11:08:14 UTC
[GitHub] [spark] LuciferYang opened a new pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
LuciferYang opened a new pull request #32003:
URL: https://github.com/apache/spark/pull/32003
### What changes were proposed in this pull request?
Some `spark-submit` commands used to run benchmarks in the user's guide is wrong, we can't use these commands to run benchmarks successful.
So the major changes of this pr is correct these wrong commands, for example, run a benchmark which inherits from `SqlBasedBenchmark`, we must specify `--jars <spark core test jar>,<spark catalyst test jar>` because `SqlBasedBenchmark` based benchmark extends `BenchmarkBase(defined in spark core test jar)` and `SQLHelper(defined in spark catalyst test jar)`.
Another change of this pr is removed the `scalatest Assertions` dependency of Benchmarks because `scalatest-*.jar` are not in the distribution package, it will be troublesome to use.
### Why are the changes needed?
Make sure benchmarks can run using spark-submit cmd described in the guide
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Use the corrected `spark-submit` commands to run benchmarks successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810190132
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41293/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810316190
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136711/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810333893
Merged to branch-3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810303984
**[Test build #136711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136711/testReport)** for PR 32003 at commit [`6c4b0d5`](https://github.com/apache/spark/commit/6c4b0d59e9539dca8386199dad0a311f3d409446).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810316190
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136711/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32003:
URL: https://github.com/apache/spark/pull/32003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810190345
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41293/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810190345
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41293/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810150988
**[Test build #136711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136711/testReport)** for PR 32003 at commit [`6c4b0d5`](https://github.com/apache/spark/commit/6c4b0d59e9539dca8386199dad0a311f3d409446).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810182156
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41293/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32003: [SPARK-34900][TEST][3.0] Make sure benchmarks can run using spark-submit cmd described in the guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32003:
URL: https://github.com/apache/spark/pull/32003#issuecomment-810150988
**[Test build #136711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136711/testReport)** for PR 32003 at commit [`6c4b0d5`](https://github.com/apache/spark/commit/6c4b0d59e9539dca8386199dad0a311f3d409446).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org