You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/02/26 16:29:14 UTC
[GitHub] [maven-jdeprscan-plugin] bmarwell opened a new pull request #1: Remove duplicate code snippet, extract into method.
bmarwell opened a new pull request #1:
URL: https://github.com/apache/maven-jdeprscan-plugin/pull/1
- Convert line breaks to unix
- Removed code duplication, refactored into a method
- made map field `final`. The convention says "Avoid using final modifier on all fields and arguments", but on collections they enforce a specific coding behaviour (i.e. never replace them).
- order imports alphabetically (consistently)
- return unmodifiable collections. Not modifying collections you did not create yourself is considered a "good habit". As this is a new plugin which has not been released yet, let's enforce it.
Hint: sadly github/git shows the whole file as replaced. Consider using your favourite IDE/vim/emacs/etc. for a better diff of `JDeprScanConsumer.java`.
Those are all just nits. Just a preparation for the next feature, which might be scanning of dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jdeprscan-plugin] slachiewicz merged pull request #1: Remove duplicate code snippet, extract into method.
Posted by GitBox <gi...@apache.org>.
slachiewicz merged pull request #1:
URL: https://github.com/apache/maven-jdeprscan-plugin/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jdeprscan-plugin] slachiewicz merged pull request #1: Remove duplicate code snippet, extract into method.
Posted by GitBox <gi...@apache.org>.
slachiewicz merged pull request #1:
URL: https://github.com/apache/maven-jdeprscan-plugin/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org