You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2016/06/24 07:05:14 UTC
[36/50] kylin git commit: refactor: subclass of AbstractExecutable
change to use own logger
refactor: subclass of AbstractExecutable change to use own logger
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/94567c15
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/94567c15
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/94567c15
Branch: refs/heads/stream_m1
Commit: 94567c150e94d0f6499bb26621869c83d117c5a4
Parents: bfee5ed
Author: Hongbin Ma <ma...@apache.org>
Authored: Wed Jun 22 17:51:55 2016 +0800
Committer: Hongbin Ma <ma...@apache.org>
Committed: Wed Jun 22 17:52:03 2016 +0800
----------------------------------------------------------------------
.../kylin/job/common/ShellExecutable.java | 4 ++++
.../kylin/job/execution/AbstractExecutable.java | 2 +-
.../org/apache/kylin/engine/mr/CubingJob.java | 4 ++++
.../engine/mr/common/HadoopShellExecutable.java | 4 ++++
.../UpdateIIInfoAfterBuildStep.java | 4 ++++
.../engine/mr/steps/MergeDictionaryStep.java | 5 ++++
.../engine/mr/steps/MergeStatisticsStep.java | 4 ++++
.../engine/mr/steps/SaveStatisticsStep.java | 4 ++++
.../mr/steps/UpdateCubeInfoAfterBuildStep.java | 4 ++++
.../mr/steps/UpdateCubeInfoAfterMergeStep.java | 4 ++++
.../kylin/engine/spark/SparkExecutable.java | 4 ++++
.../source/hive/CreateFlatHiveTableStep.java | 4 ++++
.../apache/kylin/source/hive/HiveMRInput.java | 25 +++++++++++---------
.../apache/kylin/source/hive/HqlExecutable.java | 4 ++++
.../steps/HDFSPathGarbageCollectionStep.java | 5 ++++
15 files changed, 69 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/core-job/src/main/java/org/apache/kylin/job/common/ShellExecutable.java
----------------------------------------------------------------------
diff --git a/core-job/src/main/java/org/apache/kylin/job/common/ShellExecutable.java b/core-job/src/main/java/org/apache/kylin/job/common/ShellExecutable.java
index 74f54a1..209d14e 100644
--- a/core-job/src/main/java/org/apache/kylin/job/common/ShellExecutable.java
+++ b/core-job/src/main/java/org/apache/kylin/job/common/ShellExecutable.java
@@ -32,11 +32,15 @@ import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
import com.google.common.collect.Maps;
+import org.slf4j.LoggerFactory;
/**
*/
public class ShellExecutable extends AbstractExecutable {
+ private static final org.slf4j.Logger logger = LoggerFactory.getLogger(ShellExecutable.class);
+
+
private static final String CMD = "cmd";
public ShellExecutable() {
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
----------------------------------------------------------------------
diff --git a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
index 395676b..778763c 100644
--- a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
+++ b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
@@ -49,7 +49,7 @@ public abstract class AbstractExecutable implements Executable, Idempotent {
protected static final String START_TIME = "startTime";
protected static final String END_TIME = "endTime";
- protected static final Logger logger = LoggerFactory.getLogger(AbstractExecutable.class);
+ private static final Logger logger = LoggerFactory.getLogger(AbstractExecutable.class);
protected int retry = 0;
private String name;
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java
index 70b6132..bbd0fc5 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java
@@ -42,11 +42,15 @@ import org.apache.kylin.job.execution.ExecuteResult;
import org.apache.kylin.job.execution.Output;
import org.apache.kylin.metadata.project.ProjectInstance;
import org.apache.kylin.metadata.project.ProjectManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
*/
public class CubingJob extends DefaultChainedExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(CubingJob.class);
+
public enum AlgorithmEnum {
LAYER, INMEM
}
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java
index aebae1a..56aa3c8 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java
@@ -30,10 +30,14 @@ import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
*/
public class HadoopShellExecutable extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(HadoopShellExecutable.class);
+
private static final String KEY_MR_JOB = "HADOOP_SHELL_JOB_CLASS";
private static final String KEY_PARAMS = "HADOOP_SHELL_JOB_PARAMS";
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/invertedindex/UpdateIIInfoAfterBuildStep.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/invertedindex/UpdateIIInfoAfterBuildStep.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/invertedindex/UpdateIIInfoAfterBuildStep.java
index ef9b1c3..2652f07 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/invertedindex/UpdateIIInfoAfterBuildStep.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/invertedindex/UpdateIIInfoAfterBuildStep.java
@@ -31,12 +31,16 @@ import org.apache.kylin.job.execution.AbstractExecutable;
import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
import org.apache.kylin.metadata.model.SegmentStatusEnum;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import java.io.IOException;
/**
*/
public class UpdateIIInfoAfterBuildStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(UpdateIIInfoAfterBuildStep.class);
+
private static final String II_NAME = "iiName";
private static final String JOB_ID = "jobId";
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryStep.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryStep.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryStep.java
index f0c69c8..e7aa698 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryStep.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeDictionaryStep.java
@@ -40,9 +40,14 @@ import org.apache.kylin.job.execution.ExecuteResult;
import org.apache.kylin.metadata.model.TblColRef;
import com.google.common.collect.Lists;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class MergeDictionaryStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(MergeDictionaryStep.class);
+
+
public MergeDictionaryStep() {
super();
}
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java
index fa6f9e2..486bd9c 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MergeStatisticsStep.java
@@ -50,8 +50,12 @@ import org.apache.kylin.job.execution.ExecuteResult;
import org.apache.kylin.measure.hllc.HyperLogLogPlusCounter;
import com.google.common.collect.Maps;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class MergeStatisticsStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(MergeStatisticsStep.class);
+
protected Map<Long, HyperLogLogPlusCounter> cuboidHLLMap = Maps.newHashMap();
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/SaveStatisticsStep.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/SaveStatisticsStep.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/SaveStatisticsStep.java
index 721cd35..435fb13 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/SaveStatisticsStep.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/SaveStatisticsStep.java
@@ -40,6 +40,8 @@ import org.apache.kylin.job.execution.AbstractExecutable;
import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
import org.apache.kylin.metadata.model.MeasureDesc;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Save the cube segment statistic to Kylin metadata store
@@ -47,6 +49,8 @@ import org.apache.kylin.metadata.model.MeasureDesc;
*/
public class SaveStatisticsStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(SaveStatisticsStep.class);
+
public SaveStatisticsStep() {
super();
}
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterBuildStep.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterBuildStep.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterBuildStep.java
index 137f6c2..17ce5d0 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterBuildStep.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterBuildStep.java
@@ -28,10 +28,14 @@ import org.apache.kylin.job.exception.ExecuteException;
import org.apache.kylin.job.execution.AbstractExecutable;
import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
*/
public class UpdateCubeInfoAfterBuildStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(UpdateCubeInfoAfterBuildStep.class);
+
public UpdateCubeInfoAfterBuildStep() {
super();
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterMergeStep.java
----------------------------------------------------------------------
diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterMergeStep.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterMergeStep.java
index 38ed906..5846caa 100644
--- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterMergeStep.java
+++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/UpdateCubeInfoAfterMergeStep.java
@@ -35,12 +35,16 @@ import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
import com.google.common.collect.Lists;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
*/
public class UpdateCubeInfoAfterMergeStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(UpdateCubeInfoAfterMergeStep.class);
+
private final CubeManager cubeManager = CubeManager.getInstance(KylinConfig.getInstanceFromEnv());
public UpdateCubeInfoAfterMergeStep() {
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
----------------------------------------------------------------------
diff --git a/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java b/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
index fd37cfa..105433d 100644
--- a/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
+++ b/engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
@@ -29,11 +29,15 @@ import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
import com.google.common.base.Preconditions;
+import org.slf4j.LoggerFactory;
/**
*/
public class SparkExecutable extends AbstractExecutable {
+ private static final org.slf4j.Logger logger = LoggerFactory.getLogger(SparkExecutable.class);
+
+
private static final String CLASS_NAME = "className";
public void setClassName(String className) {
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableStep.java
----------------------------------------------------------------------
diff --git a/source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableStep.java b/source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableStep.java
index 443de99..93a30d6 100644
--- a/source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableStep.java
+++ b/source-hive/src/main/java/org/apache/kylin/source/hive/CreateFlatHiveTableStep.java
@@ -14,6 +14,8 @@ import org.apache.kylin.job.exception.ExecuteException;
import org.apache.kylin.job.execution.AbstractExecutable;
import org.apache.kylin.job.execution.ExecutableContext;
import org.apache.kylin.job.execution.ExecuteResult;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.io.InputStream;
@@ -21,6 +23,8 @@ import java.io.InputStream;
/**
*/
public class CreateFlatHiveTableStep extends AbstractExecutable {
+
+ private static final Logger logger = LoggerFactory.getLogger(CreateFlatHiveTableStep.class);
private final BufferedLogger stepLogger = new BufferedLogger(logger);
private long readRowCountFromFile() throws IOException {
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/source-hive/src/main/java/org/apache/kylin/source/hive/HiveMRInput.java
----------------------------------------------------------------------
diff --git a/source-hive/src/main/java/org/apache/kylin/source/hive/HiveMRInput.java b/source-hive/src/main/java/org/apache/kylin/source/hive/HiveMRInput.java
index 5af8eb9..6e5c47c 100644
--- a/source-hive/src/main/java/org/apache/kylin/source/hive/HiveMRInput.java
+++ b/source-hive/src/main/java/org/apache/kylin/source/hive/HiveMRInput.java
@@ -21,7 +21,6 @@ package org.apache.kylin.source.hive;
import java.io.IOException;
import java.util.Set;
-import com.google.common.collect.Sets;
import org.apache.commons.lang.StringUtils;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
@@ -31,7 +30,6 @@ import org.apache.hive.hcatalog.mapreduce.HCatInputFormat;
import org.apache.kylin.common.KylinConfig;
import org.apache.kylin.cube.CubeManager;
import org.apache.kylin.cube.model.CubeDesc;
-import org.apache.kylin.cube.model.DimensionDesc;
import org.apache.kylin.engine.mr.HadoopUtil;
import org.apache.kylin.engine.mr.IMRInput;
import org.apache.kylin.engine.mr.JobBuilderSupport;
@@ -50,6 +48,10 @@ import org.apache.kylin.metadata.model.IJoinedFlatTableDesc;
import org.apache.kylin.metadata.model.LookupDesc;
import org.apache.kylin.metadata.model.TableDesc;
import org.apache.kylin.metadata.realization.IRealizationSegment;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.collect.Sets;
public class HiveMRInput implements IMRInput {
@@ -118,7 +120,7 @@ public class HiveMRInput implements IMRInput {
jobFlow.addTask(createCountHiveTableStep(conf, flatHiveTableDesc, jobFlow.getId(), rowCountOutputDir));
jobFlow.addTask(createFlatHiveTableStep(conf, flatHiveTableDesc, jobFlow.getId(), cubeName, rowCountOutputDir));
AbstractExecutable task = createLookupHiveViewMaterializationStep(jobFlow.getId());
- if(task != null) {
+ if (task != null) {
jobFlow.addTask(task);
}
}
@@ -138,7 +140,8 @@ public class HiveMRInput implements IMRInput {
}
public ShellExecutable createLookupHiveViewMaterializationStep(String jobId) {
- ShellExecutable step = new ShellExecutable();;
+ ShellExecutable step = new ShellExecutable();
+ ;
step.setName(ExecutableConstants.STEP_NAME_MATERIALIZE_HIVE_VIEW_IN_LOOKUP);
HiveCmdBuilder hiveCmdBuilder = new HiveCmdBuilder();
@@ -156,20 +159,18 @@ public class HiveMRInput implements IMRInput {
}
}
- if(lookupViewsTables.size() == 0) {
+ if (lookupViewsTables.size() == 0) {
return null;
}
final String useDatabaseHql = "USE " + conf.getConfig().getHiveDatabaseForIntermediateTable() + ";";
hiveCmdBuilder.addStatement(useDatabaseHql);
hiveCmdBuilder.addStatement(JoinedFlatTable.generateHiveSetStatements(conf));
- for(TableDesc lookUpTableDesc : lookupViewsTables) {
+ for (TableDesc lookUpTableDesc : lookupViewsTables) {
if (TableDesc.TABLE_TYPE_VIRTUAL_VIEW.equalsIgnoreCase(lookUpTableDesc.getTableType())) {
StringBuilder createIntermediateTableHql = new StringBuilder();
createIntermediateTableHql.append("DROP TABLE IF EXISTS " + lookUpTableDesc.getMaterializedName() + ";\n");
- createIntermediateTableHql.append("CREATE TABLE IF NOT EXISTS " +
- lookUpTableDesc.getMaterializedName() + "\n");
- createIntermediateTableHql.append("LOCATION '" + JobBuilderSupport.getJobWorkingDir(conf, jobId) + "/" +
- lookUpTableDesc.getMaterializedName() + "'\n");
+ createIntermediateTableHql.append("CREATE TABLE IF NOT EXISTS " + lookUpTableDesc.getMaterializedName() + "\n");
+ createIntermediateTableHql.append("LOCATION '" + JobBuilderSupport.getJobWorkingDir(conf, jobId) + "/" + lookUpTableDesc.getMaterializedName() + "'\n");
createIntermediateTableHql.append("AS SELECT * FROM " + lookUpTableDesc.getIdentity() + ";\n");
hiveCmdBuilder.addStatement(createIntermediateTableHql.toString());
hiveViewIntermediateTables = hiveViewIntermediateTables + lookUpTableDesc.getMaterializedName() + ";";
@@ -222,6 +223,8 @@ public class HiveMRInput implements IMRInput {
}
public static class GarbageCollectionStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(GarbageCollectionStep.class);
+
@Override
protected ExecuteResult doWork(ExecutableContext context) throws ExecuteException {
KylinConfig config = context.getConfig();
@@ -276,7 +279,7 @@ public class HiveMRInput implements IMRInput {
final HiveCmdBuilder hiveCmdBuilder = new HiveCmdBuilder();
hiveCmdBuilder.addStatement("USE " + config.getHiveDatabaseForIntermediateTable() + ";");
if (getHiveViewIntermediateTableIdentities() != null && !getHiveViewIntermediateTableIdentities().isEmpty()) {
- for(String hiveTableName : getHiveViewIntermediateTableIdentities().split(";")) {
+ for (String hiveTableName : getHiveViewIntermediateTableIdentities().split(";")) {
hiveCmdBuilder.addStatement("DROP TABLE IF EXISTS " + hiveTableName + ";");
}
}
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/source-hive/src/main/java/org/apache/kylin/source/hive/HqlExecutable.java
----------------------------------------------------------------------
diff --git a/source-hive/src/main/java/org/apache/kylin/source/hive/HqlExecutable.java b/source-hive/src/main/java/org/apache/kylin/source/hive/HqlExecutable.java
index 5a105a0..cb73fc2 100644
--- a/source-hive/src/main/java/org/apache/kylin/source/hive/HqlExecutable.java
+++ b/source-hive/src/main/java/org/apache/kylin/source/hive/HqlExecutable.java
@@ -32,11 +32,15 @@ import org.datanucleus.store.types.backed.HashMap;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.google.common.collect.Lists;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
*/
public class HqlExecutable extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(HqlExecutable.class);
+
private static final String HQL = "hql";
private static final String HIVE_CONFIG = "hive-config";
http://git-wip-us.apache.org/repos/asf/kylin/blob/94567c15/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HDFSPathGarbageCollectionStep.java
----------------------------------------------------------------------
diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HDFSPathGarbageCollectionStep.java b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HDFSPathGarbageCollectionStep.java
index e124d92..ff828b0 100644
--- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HDFSPathGarbageCollectionStep.java
+++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HDFSPathGarbageCollectionStep.java
@@ -35,12 +35,17 @@ import org.apache.kylin.job.execution.ExecuteResult;
import org.apache.kylin.storage.hbase.HBaseConnection;
import com.google.common.collect.Lists;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Created by sunyerui on 15/9/17.
*/
public class HDFSPathGarbageCollectionStep extends AbstractExecutable {
+ private static final Logger logger = LoggerFactory.getLogger(HDFSPathGarbageCollectionStep.class);
+
+
public static final String TO_DELETE_PATHS = "toDeletePaths";
private StringBuffer output;
private JobEngineConfig config;