You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:24:13 UTC
[GitHub] [trafficserver] WolfgangBai opened a new pull request #7138: remove useless shortopt
WolfgangBai opened a new pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138
remap.config can't support @pparam=-p lru for middle space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7138: remove useless shortopt
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#issuecomment-681050759
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7138: remove useless shortopt
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#discussion_r477599900
##########
File path: plugins/cache_promote/configs.cc
##########
@@ -48,7 +48,7 @@ bool
PromotionConfig::factory(int argc, char *argv[])
{
while (true) {
- int opt = getopt_long(argc, (char *const *)argv, "psbhe", longopt, nullptr);
Review comment:
The short options value is needed if you want to allow sort options.
However, the short options are not documented:
https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cache_promote.en.html?highlight=promotion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7138: Remove useless shortopt
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#issuecomment-681142036
I'm ok with this, but, kinda wish we'd fix the core instead to allow quoted @pparam's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a change in pull request #7138: remove useless shortopt
Posted by GitBox <gi...@apache.org>.
bryancall commented on a change in pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#discussion_r477599900
##########
File path: plugins/cache_promote/configs.cc
##########
@@ -48,7 +48,7 @@ bool
PromotionConfig::factory(int argc, char *argv[])
{
while (true) {
- int opt = getopt_long(argc, (char *const *)argv, "psbhe", longopt, nullptr);
Review comment:
The short options value is needed if you want to allow sort options.
However, the short options are not documented:
https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/cache_promote.en.html?highlight=promotion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #7138: Remove useless shortopt
Posted by GitBox <gi...@apache.org>.
zwoop merged pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7138: remove useless shortopt
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#issuecomment-681137618
Looks like quoting remap params doesn't works, so it is kinda of pointless to have short options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7138: remove useless shortopt
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#issuecomment-680907344
[approve ci]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7138: Remove useless shortopt
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7138:
URL: https://github.com/apache/trafficserver/pull/7138#issuecomment-682032395
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org