You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Kevin Risden (Jira)" <ji...@apache.org> on 2023/01/23 14:45:00 UTC
[jira] [Comment Edited] (SOLR-15616) Allow thread metrics to be cached
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679827#comment-17679827 ]
Kevin Risden edited comment on SOLR-15616 at 1/23/23 2:44 PM:
--------------------------------------------------------------
{quote}I do `git clean -fdx` every time before running these checks. Does that suffice?{quote}
Hopefully you could answer your own question:
{code:java}
git clean -fdxn
Would remove .gradle/
Would remove .idea/
Would remove build/
Would remove buildSrc/.gradle/
Would remove buildSrc/build/
Would remove dev-tools/solr-missing-doclet/.gradle/
Would remove dev-tools/solr-missing-doclet/build/
Would remove gradle.properties
Would remove gradle/wrapper/gradle-wrapper.jar
Would remove solr/benchmark/build/
Would remove solr/benchmark/work/
Would remove solr/build/
Would remove solr/core/build/
Would remove solr/core/src/test-files/solr/configsets/.DS_Store
Would remove solr/distribution/build/
Would remove solr/docker/build/
Would remove solr/documentation/build/
Would remove solr/example/build/
Would remove solr/modules/analysis-extras/build/
Would remove solr/modules/analytics/build/
Would remove solr/modules/build/
Would remove solr/modules/clustering/build/
Would remove solr/modules/extraction/build/
Would remove solr/modules/gcs-repository/build/
Would remove solr/modules/hadoop-auth/build/
Would remove solr/modules/hdfs/build/
Would remove solr/modules/jwt-auth/build/
Would remove solr/modules/langid/build/
Would remove solr/modules/ltr/build/
Would remove solr/modules/opentelemetry/build/
Would remove solr/modules/s3-repository/build/
Would remove solr/modules/scripting/build/
Would remove solr/modules/sql/build/
Would remove solr/packaging/build/
Would remove solr/prometheus-exporter/build/
Would remove solr/server/build/
Would remove solr/solr-ref-guide/build/
Would remove solr/solrj-streaming/build/
Would remove solr/solrj-zookeeper/build/
Would remove solr/solrj/build/
Would remove solr/test-framework/build/
Would remove solr/webapp/build/
{code}
Yes it removes too much. gradle.properties needs to stay.
The other option is run `./gradlew localSettings` before running whatever command next (ie: ./gradlew check -x test)
You really shouldn't be pushing commits that you don't even run check before hand. At least push a PR which will also do these checks.
was (Author: risdenk):
{quote}I do `git clean -fdx` every time before running these checks. Does that suffice?{quote}
Hiopefully you could answer your own question:
{code:java}
git clean -fdxn
Would remove .gradle/
Would remove .idea/
Would remove build/
Would remove buildSrc/.gradle/
Would remove buildSrc/build/
Would remove dev-tools/solr-missing-doclet/.gradle/
Would remove dev-tools/solr-missing-doclet/build/
Would remove gradle.properties
Would remove gradle/wrapper/gradle-wrapper.jar
Would remove solr/benchmark/build/
Would remove solr/benchmark/work/
Would remove solr/build/
Would remove solr/core/build/
Would remove solr/core/src/test-files/solr/configsets/.DS_Store
Would remove solr/distribution/build/
Would remove solr/docker/build/
Would remove solr/documentation/build/
Would remove solr/example/build/
Would remove solr/modules/analysis-extras/build/
Would remove solr/modules/analytics/build/
Would remove solr/modules/build/
Would remove solr/modules/clustering/build/
Would remove solr/modules/extraction/build/
Would remove solr/modules/gcs-repository/build/
Would remove solr/modules/hadoop-auth/build/
Would remove solr/modules/hdfs/build/
Would remove solr/modules/jwt-auth/build/
Would remove solr/modules/langid/build/
Would remove solr/modules/ltr/build/
Would remove solr/modules/opentelemetry/build/
Would remove solr/modules/s3-repository/build/
Would remove solr/modules/scripting/build/
Would remove solr/modules/sql/build/
Would remove solr/packaging/build/
Would remove solr/prometheus-exporter/build/
Would remove solr/server/build/
Would remove solr/solr-ref-guide/build/
Would remove solr/solrj-streaming/build/
Would remove solr/solrj-zookeeper/build/
Would remove solr/solrj/build/
Would remove solr/test-framework/build/
Would remove solr/webapp/build/
{code}
Yes it removes too much. gradle.properties needs to stay.
The other option is run `./gradlew localSettings` before running whatever command next (ie: ./gradlew check -x test)
You really shouldn't be pushing commits that you don't even run check before hand.
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Attachments: SOLR-15616-2.patch, SOLR-15616-9x.patch, SOLR-15616.patch, SOLR-15616.patch
>
>
> Computing JVM metrics for threads can be expensive, and we should provide option to users to avoid doing so on every call to the metrics API (group=jvm).
> solr.xml:
> {code}
> <solr>
> <metrics enabled=true>
> <caching>
> <int name="threadsIntervalSeconds">2</int>
> </caching>
> ..
> </metrics>
> </solr>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org