[GitHub] mistercrunch commented on a change in pull request #4643: Added option to add fill to area line charts

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4643: Added option to add fill to area line charts
URL: https://github.com/apache/incubator-superset/pull/4643#discussion_r176271971
 
 

 ##########
 File path: superset/assets/visualizations/nvd3_vis.js
 ##########
 @@ -173,6 +177,16 @@ function nvd3Vis(slice, payload) {
         } else {
           chart = nv.models.lineChart();
         }
+
+        if (fd.line_fill_area) {
+          data = data.map(d => ({
+            ...d,
+            area: true,
 
 Review comment:
   Looked at the `nvd3` source code and looks like you can pass `fillOpacity: 0.05` right here under `area`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services