You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/08 12:46:03 UTC

[GitHub] [kafka] jlprat commented on pull request #11350: Scala3 migration

jlprat commented on pull request #11350:
URL: https://github.com/apache/kafka/pull/11350#issuecomment-938614404


   Current status of the PR:
   - All tests pass in Scala 3 except one (`KafkaApis#getAllTopicMetadataShouldNotCreateTopicOrReturnUnknownTopicPartition`) due to this bug with no workaround: https://github.com/lampepfl/dotty/issues/13638
   - All tests pass in Scala 2
   - It still uses a snapshot build of Gradle
   
   In this PR there are several types of changes:
   a) Needed changes because of changes in syntax or compiler being currently more strict
   b) Changes where a workaround is present but they are fixed in upcoming Scala versions
   c) Changes in the build
   
   I propose perform the Scala 3 migration in several steps:
   - Firstly apply all changes that would fall into category *a)*
   - Once a new Scala version that incorporates the mentioned fixes is released, revisit point changes in point *b)*
   - Lastly, once https://github.com/lampepfl/dotty/issues/13638 is resolved or a workaround is found and Gradle with Scala 3 support is released we could tackle the final step and incorporate changes mentioned in point *c)*
   
   
   What are your thoughts? @ijuma 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org