You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2008/04/15 23:00:21 UTC
[jira] Created: (HADOOP-3262) make Hadoop compile under Apache
Harmony
make Hadoop compile under Apache Harmony
----------------------------------------
Key: HADOOP-3262
URL: https://issues.apache.org/jira/browse/HADOOP-3262
Project: Hadoop Core
Issue Type: Bug
Components: build
Reporter: Doug Cutting
Some small changes are required to get Hadoop Core to compile with Apache Harmony.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3262) make Hadoop compile under Apache
Harmony
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590087#action_12590087 ]
Owen O'Malley commented on HADOOP-3262:
---------------------------------------
+1
Does this also resolve HADOOP-1826?
> make Hadoop compile under Apache Harmony
> ----------------------------------------
>
> Key: HADOOP-3262
> URL: https://issues.apache.org/jira/browse/HADOOP-3262
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Doug Cutting
> Attachments: HADOOP-3262.patch
>
>
> Some small changes are required to get Hadoop Core to compile with Apache Harmony.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3262) make Hadoop compile under Apache
Harmony
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3262:
----------------------------------
Status: Open (was: Patch Available)
This patch doesn't compile under Mac OS. The change to the compare method is wrong because JobEndStatusInfo implements Delayed and Delayed implements Comparable<Delayed>.
{code}
[javac] /Users/oom/work/eclipse/hadoop-trunk/src/java/org/apache/hadoop/mapred/JobEndNotifier.java:169: org.apache.hadoop.mapred.JobEndNotifier.JobEndStatusInfo is not abstract and does not override abstract method compareTo(java.util.concurrent.Delayed) in java.lang.Comparable
[javac] private static class JobEndStatusInfo implements Delayed {
[javac] ^
{code}
and therefore the compare's operand should be Delayed. I suspect this is a bug in Harmony.
> make Hadoop compile under Apache Harmony
> ----------------------------------------
>
> Key: HADOOP-3262
> URL: https://issues.apache.org/jira/browse/HADOOP-3262
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Attachments: HADOOP-3262.patch
>
>
> Some small changes are required to get Hadoop Core to compile with Apache Harmony.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3262) make Hadoop compile under Apache
Harmony
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591739#action_12591739 ]
Doug Cutting commented on HADOOP-3262:
--------------------------------------
Sigh. I can't find a way to get a class that 'implements Delayed' to compile in both Sun Java and Harmony.
Given:
{noformat}
public interface Comparable<T> {
int compareTo(T o);
}
public interface Delayed extends Comparable<Delayed> {}
{noformat}
Harmony requires the first of the following methods, but doesn't mind the second, while Sun permits only the second.
{noformat}
public class DelayedImpl implements Delayed {
public int compareTo(Object o);
public int compareTo(Delayed o);
}
{noformat}
My hunch is that Sun is correct here and that we should file a bug against Harmony.
> make Hadoop compile under Apache Harmony
> ----------------------------------------
>
> Key: HADOOP-3262
> URL: https://issues.apache.org/jira/browse/HADOOP-3262
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Attachments: HADOOP-3262.patch
>
>
> Some small changes are required to get Hadoop Core to compile with Apache Harmony.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3262) make Hadoop compile under Apache
Harmony
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-3262:
---------------------------------
Attachment: HADOOP-3262.patch
The problems were:
- a compare() method whose signature is wrong. I think this is a bug.
- two cases with multiple top-level classes per file. I don't know if this a bug with Harmony or not, but it's not an encouraged style anyway: placing these in separate files seems like an improvement.
> make Hadoop compile under Apache Harmony
> ----------------------------------------
>
> Key: HADOOP-3262
> URL: https://issues.apache.org/jira/browse/HADOOP-3262
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Doug Cutting
> Attachments: HADOOP-3262.patch
>
>
> Some small changes are required to get Hadoop Core to compile with Apache Harmony.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3262) make Hadoop compile under Apache
Harmony
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-3262:
---------------------------------
Assignee: Doug Cutting
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> make Hadoop compile under Apache Harmony
> ----------------------------------------
>
> Key: HADOOP-3262
> URL: https://issues.apache.org/jira/browse/HADOOP-3262
> Project: Hadoop Core
> Issue Type: Bug
> Components: build
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Attachments: HADOOP-3262.patch
>
>
> Some small changes are required to get Hadoop Core to compile with Apache Harmony.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.