You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/08/19 18:48:21 UTC
[PR] [SPARK-49304] Add `-SNAPSHOT` postfix to `Spark Operator` version [spark-kubernetes-operator]
dongjoon-hyun opened a new pull request, #69:
URL: https://github.com/apache/spark-kubernetes-operator/pull/69
### What changes were proposed in this pull request?
This PR aims to add `-SNAPSHOT` postfix to `Spark Kubernetes Operator` version as a part of preparation of official release.
### Why are the changes needed?
To distinguish the dev version from the future official release.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49304] Add `-SNAPSHOT` postfix to `Spark Operator` version [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #69:
URL: https://github.com/apache/spark-kubernetes-operator/pull/69#discussion_r1722215719
##########
build.gradle:
##########
@@ -34,7 +34,7 @@ assert JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_17): "Java 17
allprojects {
group = "org.apache.spark.k8s.operator"
- version = "0.1.0"
+ version = "0.1.0-SNAPSHOT"
Review Comment:
This is the main change .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49304] Add `-SNAPSHOT` postfix to `Spark Operator` version [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-kubernetes-operator/pull/69#issuecomment-2297239770
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49304] Add `-SNAPSHOT` postfix to `Spark Operator` version [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-kubernetes-operator/pull/69#issuecomment-2297238709
Thank you for a swift review and approval, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49304] Add `-SNAPSHOT` postfix to `Spark Operator` version [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #69:
URL: https://github.com/apache/spark-kubernetes-operator/pull/69#discussion_r1722213148
##########
.github/workflows/build_and_test.yml:
##########
@@ -89,12 +89,6 @@ jobs:
kubectl create clusterrolebinding serviceaccounts-cluster-admin --clusterrole=cluster-admin --group=system:serviceaccounts || true
eval $(minikube docker-env)
./gradlew buildDockerImage
- kubectl run spark-kubernetes-operator --image=spark-kubernetes-operator:0.1.0 --restart=Never
- sleep 5
- kubectl get pods -A
- kubectl logs spark-kubernetes-operator
- kubectl delete pod spark-kubernetes-operator
- # helm
Review Comment:
`helm install` test includes the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49304] Add `-SNAPSHOT` postfix to `Spark Operator` version [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #69: [SPARK-49304] Add `-SNAPSHOT` postfix to `Spark Operator` version
URL: https://github.com/apache/spark-kubernetes-operator/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org