You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by pc...@apache.org on 2023/04/13 13:48:08 UTC
[camel-k] branch main updated (dc7f25051 -> ab793837e)
This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git
from dc7f25051 chore(ctrl): lint suggestions
new 102ce86e1 Chore: jvm/keystore_test misleading comment
new b062be2a4 chore: changed misleading comments in jvm
new ab793837e Update keystore_test.go
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pkg/util/jvm/keystore_test.go | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[camel-k] 01/03: Chore: jvm/keystore_test misleading comment
Posted by pc...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git
commit 102ce86e1fc9760f7d56cdb99744b7f9c1d9c44f
Author: Martin Olšiak <56...@users.noreply.github.com>
AuthorDate: Thu Apr 13 12:56:12 2023 +0200
Chore: jvm/keystore_test misleading comment
Changed misleading comment for one of the tests
---
pkg/util/jvm/keystore_test.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkg/util/jvm/keystore_test.go b/pkg/util/jvm/keystore_test.go
index 0b570ae84..6e09a2b9d 100644
--- a/pkg/util/jvm/keystore_test.go
+++ b/pkg/util/jvm/keystore_test.go
@@ -39,7 +39,7 @@ func TestGenerateKeystore(t *testing.T) {
err = GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(), data)
assert.NotNil(t, err)
- // Incorrect input format
+ // Incorrect password format
err = GenerateKeystore(ctx, "", "/tmp/keystore", "", data)
assert.NotNil(t, err)
[camel-k] 03/03: Update keystore_test.go
Posted by pc...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git
commit ab793837eb2a1eebf0a4774a630e64ad95cff561
Author: Martin Olšiak <56...@users.noreply.github.com>
AuthorDate: Thu Apr 13 13:15:28 2023 +0200
Update keystore_test.go
Fixed formatting
---
pkg/util/jvm/keystore_test.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkg/util/jvm/keystore_test.go b/pkg/util/jvm/keystore_test.go
index 1338f6260..ffeed9621 100644
--- a/pkg/util/jvm/keystore_test.go
+++ b/pkg/util/jvm/keystore_test.go
@@ -34,7 +34,7 @@ func TestGenerateKeystore(t *testing.T) {
err := GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(), data)
assert.Nil(t, err)
- // Non-nil data
+ // Non-Nil Data
data = [][]byte{{0}, {1}}
err = GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(), data)
assert.NotNil(t, err)
[camel-k] 02/03: chore: changed misleading comments in jvm
Posted by pc...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git
commit b062be2a4ad3888a52bc11d611a566b400bd5a08
Author: Martin Olšiak <56...@users.noreply.github.com>
AuthorDate: Thu Apr 13 13:14:54 2023 +0200
chore: changed misleading comments in jvm
Changed misleading comment for jvm/keystore_test
Rephrased comment for jvm/keystore_test
---
pkg/util/jvm/keystore_test.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pkg/util/jvm/keystore_test.go b/pkg/util/jvm/keystore_test.go
index 6e09a2b9d..1338f6260 100644
--- a/pkg/util/jvm/keystore_test.go
+++ b/pkg/util/jvm/keystore_test.go
@@ -28,13 +28,13 @@ import (
func TestGenerateKeystore(t *testing.T) {
- // No Data
+ // Nil Data
var data [][]byte
ctx := context.Background()
err := GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(), data)
assert.Nil(t, err)
- // Correct input
+ // Non-nil data
data = [][]byte{{0}, {1}}
err = GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(), data)
assert.NotNil(t, err)