You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2024/12/30 07:51:31 UTC

(skywalking-booster-ui) branch main updated: fix: set up async profiling tasks (#443)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git


The following commit(s) were added to refs/heads/main by this push:
     new 55b3867b fix: set up async profiling tasks (#443)
55b3867b is described below

commit 55b3867bea25db8f3e7a0d229a5a1787d95e7db8
Author: Fine0830 <fa...@gmail.com>
AuthorDate: Mon Dec 30 15:51:26 2024 +0800

    fix: set up async profiling tasks (#443)
---
 src/store/modules/async-profiling.ts                                | 5 ++++-
 src/store/modules/topology.ts                                       | 6 +++---
 src/utils/vec2.ts                                                   | 4 ++--
 src/utils/vec3.ts                                                   | 4 ++--
 src/views/dashboard/related/async-profiling/components/TaskList.vue | 2 +-
 .../dashboard/related/network-profiling/components/Graph/layout.ts  | 2 +-
 src/views/dashboard/related/profile/Content.vue                     | 4 ++--
 src/views/dashboard/related/trace/TraceList.vue                     | 2 +-
 src/views/dashboard/related/trace/utils/d3-trace-list.ts            | 2 +-
 src/views/dashboard/related/trace/utils/d3-trace-tree.ts            | 2 +-
 tsconfig.vitest.json                                                | 1 +
 11 files changed, 19 insertions(+), 15 deletions(-)

diff --git a/src/store/modules/async-profiling.ts b/src/store/modules/async-profiling.ts
index a0041f18..de865c8c 100644
--- a/src/store/modules/async-profiling.ts
+++ b/src/store/modules/async-profiling.ts
@@ -96,7 +96,10 @@ export const asyncProfilingStore = defineStore({
         duration: useAppStoreWithOut().durationTime,
       });
       if (!res.data.errors) {
-        this.instances = res.data.data.pods || [];
+        this.instances = (res.data.data.pods || []).map((d: Instance) => {
+          d.value = d.id || "";
+          return d;
+        });
       }
       return res.data;
     },
diff --git a/src/store/modules/topology.ts b/src/store/modules/topology.ts
index 80a25808..d4a580b6 100644
--- a/src/store/modules/topology.ts
+++ b/src/store/modules/topology.ts
@@ -349,7 +349,7 @@ export const topologyStore = defineStore({
         const json = await this.getEndpointTopology(ids);
         if (depth > 2) {
           const pods = json.nodes
-            .filter((d: Node) => ![...ids, ...endpointIds].includes(d.id) && d.name != userNodeName)
+            .filter((d: Node) => ![...ids, ...endpointIds].includes(d.id) && d.name !== userNodeName)
             .map((item: Node) => item.id);
           if (!pods.length) {
             const nodes = [...res.nodes, ...json.nodes];
@@ -360,7 +360,7 @@ export const topologyStore = defineStore({
           const topo = await this.getEndpointTopology(pods);
           if (depth > 3) {
             const endpoints = topo.nodes
-              .filter((d: Node) => ![...ids, ...pods, ...endpointIds].includes(d.id) && d.name != userNodeName)
+              .filter((d: Node) => ![...ids, ...pods, ...endpointIds].includes(d.id) && d.name !== userNodeName)
               .map((item: Node) => item.id);
             if (!endpoints.length) {
               const nodes = [...res.nodes, ...json.nodes, ...topo.nodes];
@@ -373,7 +373,7 @@ export const topologyStore = defineStore({
               const nodeIds = data.nodes
                 .filter(
                   (d: Node) =>
-                    ![...endpoints, ...ids, ...pods, ...endpointIds].includes(d.id) && d.name != userNodeName,
+                    ![...endpoints, ...ids, ...pods, ...endpointIds].includes(d.id) && d.name !== userNodeName,
                 )
                 .map((item: Node) => item.id);
               if (!nodeIds.length) {
diff --git a/src/utils/vec2.ts b/src/utils/vec2.ts
index 690bff74..2eef12f8 100644
--- a/src/utils/vec2.ts
+++ b/src/utils/vec2.ts
@@ -17,7 +17,7 @@
 class Vec2 extends Float32Array {
   constructor(v?: unknown, y?: unknown) {
     super(2);
-    if (v instanceof Vec2 || v instanceof Float32Array || (v instanceof Array && v.length == 2)) {
+    if (v instanceof Vec2 || v instanceof Float32Array || (v instanceof Array && v.length === 2)) {
       this[0] = v[0];
       this[1] = v[1];
     } else if (typeof v === "number" && typeof y === "number") {
@@ -104,7 +104,7 @@ class Vec2 extends Float32Array {
   }
   norm(out?: number[] | Vec2): number[] | Vec2 | undefined {
     const mag = Math.sqrt(this[0] * this[0] + this[1] * this[1]);
-    if (mag == 0) return this;
+    if (mag === 0) return this;
     out = out || this;
     out[0] = this[0] / mag;
     out[1] = this[1] / mag;
diff --git a/src/utils/vec3.ts b/src/utils/vec3.ts
index 3650fd06..d3afdc6a 100644
--- a/src/utils/vec3.ts
+++ b/src/utils/vec3.ts
@@ -17,7 +17,7 @@
 class Vec3 extends Float32Array {
   constructor(v?: unknown, y?: unknown, z?: unknown) {
     super(3);
-    if (v instanceof Vec3 || v instanceof Float32Array || (v instanceof Array && v.length == 3)) {
+    if (v instanceof Vec3 || v instanceof Float32Array || (v instanceof Array && v.length === 3)) {
       this[0] = v[0];
       this[1] = v[1];
       this[2] = v[2];
@@ -150,7 +150,7 @@ class Vec3 extends Float32Array {
   }
   static norm(x: unknown, y: unknown, z: unknown): Vec3 {
     const rtn = new Vec3();
-    if (x instanceof Vec3 || x instanceof Float32Array || (x instanceof Array && x.length == 3)) {
+    if (x instanceof Vec3 || x instanceof Float32Array || (x instanceof Array && x.length === 3)) {
       rtn.copy(x);
     } else if (typeof x === "number" && typeof y === "number" && typeof z === "number") {
       rtn.xyz(x, y, z);
diff --git a/src/views/dashboard/related/async-profiling/components/TaskList.vue b/src/views/dashboard/related/async-profiling/components/TaskList.vue
index 7b8b3e24..e1ddf785 100644
--- a/src/views/dashboard/related/async-profiling/components/TaskList.vue
+++ b/src/views/dashboard/related/async-profiling/components/TaskList.vue
@@ -41,7 +41,7 @@ limitations under the License. -->
                 {{ dateFormat(i.createTime) }}
               </span>
               <span class="mr-10 sm">
-                {{ dateFormat(i.createTime + i.duration * 60 * 1000) }}
+                {{ dateFormat(i.createTime + i.duration * 1000) }}
               </span>
             </div>
           </td>
diff --git a/src/views/dashboard/related/network-profiling/components/Graph/layout.ts b/src/views/dashboard/related/network-profiling/components/Graph/layout.ts
index ac52d56e..9c96803a 100644
--- a/src/views/dashboard/related/network-profiling/components/Graph/layout.ts
+++ b/src/views/dashboard/related/network-profiling/components/Graph/layout.ts
@@ -91,7 +91,7 @@ class Hex extends Int16Array {
   }
 
   xyz(x: number, y: number, z: number | null = null): Hex {
-    if (z == null) z = -x - y;
+    if (z === null) z = -x - y;
     if (x + y + z != 0) {
       console.log("Bad Axial Coordinate : : q %d r %d s %d", x, y, z);
     }
diff --git a/src/views/dashboard/related/profile/Content.vue b/src/views/dashboard/related/profile/Content.vue
index 2adcfc94..622b2411 100644
--- a/src/views/dashboard/related/profile/Content.vue
+++ b/src/views/dashboard/related/profile/Content.vue
@@ -21,9 +21,9 @@ limitations under the License. -->
     <div class="item">
       <SpanTree @loading="loadTrees" @displayMode="setDisplayMode" />
       <div class="thread-stack">
-        <div id="graph-stack" ref="graph" v-show="displayMode == 'flame'" />
+        <div id="graph-stack" ref="graph" v-show="displayMode === 'flame'" />
         <StackTable
-          v-show="displayMode == 'tree'"
+          v-show="displayMode === 'tree'"
           v-if="profileStore.analyzeTrees.length"
           :data="profileStore.analyzeTrees"
           :highlightTop="profileStore.highlightTop"
diff --git a/src/views/dashboard/related/trace/TraceList.vue b/src/views/dashboard/related/trace/TraceList.vue
index e9eb6625..0ebe32ec 100644
--- a/src/views/dashboard/related/trace/TraceList.vue
+++ b/src/views/dashboard/related/trace/TraceList.vue
@@ -46,7 +46,7 @@ limitations under the License. -->
             :class="{
               'trace-success': !i.isError,
               'trace-error': i.isError,
-              selected: selectedKey == i.key,
+              selected: selectedKey === i.key,
             }"
           >
             <div
diff --git a/src/views/dashboard/related/trace/utils/d3-trace-list.ts b/src/views/dashboard/related/trace/utils/d3-trace-list.ts
index 6755e234..1847add2 100644
--- a/src/views/dashboard/related/trace/utils/d3-trace-list.ts
+++ b/src/views/dashboard/related/trace/utils/d3-trace-list.ts
@@ -321,7 +321,7 @@ export default class ListGraph {
       )
       .on("click", (event: any, d: Recordable) => {
         event.stopPropagation();
-        if (d.data.children.length == 0) return;
+        if (d.data.children.length === 0) return;
         this.click(d, this);
       });
     nodeUpdate
diff --git a/src/views/dashboard/related/trace/utils/d3-trace-tree.ts b/src/views/dashboard/related/trace/utils/d3-trace-tree.ts
index 8ecc376d..bf9264c0 100644
--- a/src/views/dashboard/related/trace/utils/d3-trace-tree.ts
+++ b/src/views/dashboard/related/trace/utils/d3-trace-tree.ts
@@ -296,7 +296,7 @@ export default class TraceMap {
       .attr("cursor", "pointer")
       .on("click", (event: any, d: Recordable) => {
         event.stopPropagation();
-        if (d.data.children.length == 0) return;
+        if (d.data.children.length === 0) return;
         click(d);
       });
     const nodeExit = node
diff --git a/tsconfig.vitest.json b/tsconfig.vitest.json
index 6a78a1b3..5bf7652f 100644
--- a/tsconfig.vitest.json
+++ b/tsconfig.vitest.json
@@ -18,6 +18,7 @@
   "extends": "./tsconfig.app.json",
   "exclude": [],
   "compilerOptions": {
+    "target": "esnext",
     "lib": [],
     "types": ["node", "jsdom"]
   }