You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2024/02/03 08:35:43 UTC
(camel) 01/03: CAMEL-20389: fixed incorrectly named tests on camel-google-sheets
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit d43eea31ba3c33a505217a012fb02c686800dc20
Author: Otavio R. Piske <an...@gmail.com>
AuthorDate: Sat Feb 3 09:02:47 2024 +0100
CAMEL-20389: fixed incorrectly named tests on camel-google-sheets
Signed-off-by: Otavio R. Piske <an...@gmail.com>
---
.../camel/component/google/sheets/SheetsSpreadsheetsIT.java | 10 +++++++---
.../component/google/sheets/SheetsSpreadsheetsValuesIT.java | 13 +++++++++----
...umerIntegrationTest.java => SheetsStreamConsumerIT.java} | 9 ++++++---
3 files changed, 22 insertions(+), 10 deletions(-)
diff --git a/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsIT.java b/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsIT.java
index f2c6580abfb..c01b33be94e 100644
--- a/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsIT.java
+++ b/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsIT.java
@@ -32,6 +32,7 @@ import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.google.sheets.internal.GoogleSheetsApiCollection;
import org.apache.camel.component.google.sheets.internal.GoogleSheetsConstants;
import org.apache.camel.component.google.sheets.internal.SheetsSpreadsheetsApiMethod;
+import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -48,7 +49,8 @@ public class SheetsSpreadsheetsIT {
private static final String PATH_PREFIX
= GoogleSheetsApiCollection.getCollection().getApiName(SheetsSpreadsheetsApiMethod.class).getName();
- public static class CreateTest extends AbstractGoogleSheetsTestSupport {
+ @Nested
+ class CreateIT extends AbstractGoogleSheetsTestSupport {
private String title = "camel-sheets-" + new SecureRandom().nextInt(Integer.MAX_VALUE);
@Test
@@ -85,7 +87,8 @@ public class SheetsSpreadsheetsIT {
}
}
- public static class GetTest extends AbstractGoogleSheetsTestSupport {
+ @Nested
+ class GetIT extends AbstractGoogleSheetsTestSupport {
private Spreadsheet testSheet = getSpreadsheet();
@Test
@@ -115,7 +118,8 @@ public class SheetsSpreadsheetsIT {
}
}
- public static class BatchUpdateTest extends AbstractGoogleSheetsTestSupport {
+ @Nested
+ class BatchUpdateIT extends AbstractGoogleSheetsTestSupport {
private Spreadsheet testSheet = getSpreadsheet();
private String updateTitle = "updated-" + testSheet.getProperties().getTitle();
diff --git a/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsValuesIT.java b/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsValuesIT.java
index 582316b036f..d1e89eef259 100644
--- a/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsValuesIT.java
+++ b/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/SheetsSpreadsheetsValuesIT.java
@@ -36,6 +36,7 @@ import org.apache.camel.component.google.sheets.internal.GoogleSheetsApiCollecti
import org.apache.camel.component.google.sheets.internal.GoogleSheetsConstants;
import org.apache.camel.component.google.sheets.internal.SheetsSpreadsheetsValuesApiMethod;
import org.apache.camel.util.ObjectHelper;
+import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -53,7 +54,8 @@ public class SheetsSpreadsheetsValuesIT {
private static final String PATH_PREFIX
= GoogleSheetsApiCollection.getCollection().getApiName(SheetsSpreadsheetsValuesApiMethod.class).getName();
- public static class GetTest extends AbstractGoogleSheetsTestSupport {
+ @Nested
+ class GetIT extends AbstractGoogleSheetsTestSupport {
private Spreadsheet testSheet = getSpreadsheet();
@Test
@@ -92,7 +94,8 @@ public class SheetsSpreadsheetsValuesIT {
}
}
- public static class UpdateTest extends AbstractGoogleSheetsTestSupport {
+ @Nested
+ class UpdateIT extends AbstractGoogleSheetsTestSupport {
private Spreadsheet testSheet = getSpreadsheet();
private String range = "TEST_SHEET!A1:B2";
private List<List<Object>> data = Arrays.asList(
@@ -153,7 +156,8 @@ public class SheetsSpreadsheetsValuesIT {
}
}
- public static class AppendTest extends AbstractGoogleSheetsTestSupport {
+ @Nested
+ class AppendIT extends AbstractGoogleSheetsTestSupport {
private Spreadsheet testSheet = getSpreadsheet();
private List<List<Object>> data = Collections.singletonList(Arrays.asList("A10", "B10", "C10"));
private String range = TEST_SHEET + "!A10";
@@ -211,7 +215,8 @@ public class SheetsSpreadsheetsValuesIT {
}
}
- public static class ClearTest extends AbstractGoogleSheetsTestSupport {
+ @Nested
+ class ClearIT extends AbstractGoogleSheetsTestSupport {
private Spreadsheet testSheet = getSpreadsheet();
@Test
diff --git a/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/stream/SheetsStreamConsumerIntegrationTest.java b/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/stream/SheetsStreamConsumerIT.java
similarity index 97%
rename from components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/stream/SheetsStreamConsumerIntegrationTest.java
rename to components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/stream/SheetsStreamConsumerIT.java
index f9205affd57..8941bb2066b 100644
--- a/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/stream/SheetsStreamConsumerIntegrationTest.java
+++ b/components/camel-google/camel-google-sheets/src/test/java/org/apache/camel/component/google/sheets/stream/SheetsStreamConsumerIT.java
@@ -32,6 +32,7 @@ import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.google.sheets.GoogleSheetsClientFactory;
import org.apache.camel.component.google.sheets.MockGoogleSheetsClientFactory;
import org.apache.camel.component.mock.MockEndpoint;
+import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import static org.apache.camel.component.google.sheets.stream.GoogleSheetsStreamConstants.MAJOR_DIMENSION;
@@ -42,7 +43,7 @@ import static org.apache.camel.component.google.sheets.stream.GoogleSheetsStream
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
-public class SheetsStreamConsumerIntegrationTest {
+public class SheetsStreamConsumerIT {
private static final ObjectMapper MAPPER = new ObjectMapper()
.setDefaultPropertyInclusion(
@@ -54,7 +55,8 @@ public class SheetsStreamConsumerIntegrationTest {
Arrays.asList("a1", "b1"),
Arrays.asList("a2", "b2"));
- public static class ConsumeValueRangeTest extends AbstractGoogleSheetsStreamTestSupport {
+ @Nested
+ class ConsumeValueRangeIT extends AbstractGoogleSheetsStreamTestSupport {
Spreadsheet testSheet = getSpreadsheet();
@Test
@@ -105,7 +107,8 @@ public class SheetsStreamConsumerIntegrationTest {
}
}
- public static class ConsumeValueRangeSplitResultsTest extends AbstractGoogleSheetsStreamTestSupport {
+ @Nested
+ class ConsumeValueRangeSplitResultsIT extends AbstractGoogleSheetsStreamTestSupport {
Spreadsheet testSheet = getSpreadsheet();
@Test