You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/14 22:28:27 UTC

[kudu-CR](branch-1.1.x) Fix RAT issues for 1.1

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5076

Change subject: Fix RAT issues for 1.1
......................................................................

Fix RAT issues for 1.1

* Adds x509_check_host.{cc,h} to the RAT exclude list. These files are
  copied from OpenSSL which has a compatible license, and which has been
  noted already in the top-level LICENSE/NOTICE files.
* Adds an Apache license header to the sample README.adoc.

Change-Id: I107b6c9e3c8e928c74a10e6e08ef7b9cad066806
---
M build-support/release/rat_exclude_files.txt
M src/kudu/client/samples/README.adoc
2 files changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/5076/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I107b6c9e3c8e928c74a10e6e08ef7b9cad066806
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR](branch-1.1.x) Fix RAT issues for 1.1

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Fix RAT issues for 1.1
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I107b6c9e3c8e928c74a10e6e08ef7b9cad066806
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.1.x) Fix RAT issues for 1.1

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Fix RAT issues for 1.1
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I107b6c9e3c8e928c74a10e6e08ef7b9cad066806
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR](branch-1.1.x) Fix RAT issues for 1.1

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Fix RAT issues for 1.1
......................................................................


Fix RAT issues for 1.1

* Adds x509_check_host.{cc,h} to the RAT exclude list. These files are
  copied from OpenSSL which has a compatible license, and which has been
  noted already in the top-level LICENSE/NOTICE files.
* Adds an Apache license header to the sample README.adoc.

Change-Id: I107b6c9e3c8e928c74a10e6e08ef7b9cad066806
Reviewed-on: http://gerrit.cloudera.org:8080/5076
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M build-support/release/rat_exclude_files.txt
M src/kudu/client/samples/README.adoc
2 files changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I107b6c9e3c8e928c74a10e6e08ef7b9cad066806
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>