You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2024/02/11 11:30:58 UTC
[PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]
zentol opened a new pull request, #24298:
URL: https://github.com/apache/flink/pull/24298
The setup of the table environment in this class ran before the MiniClusterExtension was set up and beforeEach was called, causing jobs to spawn separate mini clusters. Certain tests cases try running ~200 test cases in parallel, which overloaded the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24298:
URL: https://github.com/apache/flink/pull/24298#issuecomment-1937613995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e3bfaa1a29a42919548e39634cf08122e1aab8bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3bfaa1a29a42919548e39634cf08122e1aab8bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3bfaa1a29a42919548e39634cf08122e1aab8bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #24298:
URL: https://github.com/apache/flink/pull/24298#issuecomment-1937829068
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #24298:
URL: https://github.com/apache/flink/pull/24298#discussion_r1486016061
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/ProtobufSQLITCaseTest.java:
##########
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #24298:
URL: https://github.com/apache/flink/pull/24298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #24298:
URL: https://github.com/apache/flink/pull/24298#discussion_r1486003318
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/ProtobufSQLITCaseTest.java:
##########
Review Comment:
Can we also fix the naming in a hotfix commit? `ProtobufSQLITCaseTest` -> `ProtobufSQLITCase`
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/VeryBigPbProtoToRowTest.java:
##########
@@ -20,7 +20,7 @@
import org.apache.flink.formats.protobuf.testproto.VeryBigPbClass;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
Review Comment:
That one looks like it's accidentally added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #24298:
URL: https://github.com/apache/flink/pull/24298#discussion_r1486012414
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/VeryBigPbProtoToRowTest.java:
##########
@@ -20,7 +20,7 @@
import org.apache.flink.formats.protobuf.testproto.VeryBigPbClass;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
Review Comment:
uuuh, jup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org