You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/01/17 01:36:07 UTC

[commons-cli] branch master updated: Use isEmpty().

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git


The following commit(s) were added to refs/heads/master by this push:
     new 480802d  Use isEmpty().
480802d is described below

commit 480802dcb6fcf351a33dc6f64c9cb5b11e8058be
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jan 16 20:36:01 2021 -0500

    Use isEmpty().
---
 src/test/java/org/apache/commons/cli/OptionGroupTest.java | 12 ++++++------
 src/test/java/org/apache/commons/cli/ParserTestCase.java  |  6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/test/java/org/apache/commons/cli/OptionGroupTest.java b/src/test/java/org/apache/commons/cli/OptionGroupTest.java
index 50871d4..a59e9d2 100644
--- a/src/test/java/org/apache/commons/cli/OptionGroupTest.java
+++ b/src/test/java/org/apache/commons/cli/OptionGroupTest.java
@@ -73,7 +73,7 @@ public class OptionGroupTest
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -88,7 +88,7 @@ public class OptionGroupTest
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -103,7 +103,7 @@ public class OptionGroupTest
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -118,7 +118,7 @@ public class OptionGroupTest
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -133,7 +133,7 @@ public class OptionGroupTest
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is NOT set", !cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm no extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm no extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -198,7 +198,7 @@ public class OptionGroupTest
         assertTrue( "Confirm -d is NOT set", !cl.hasOption("d") );
         assertTrue( "Confirm -s is set", cl.hasOption("s") );
         assertTrue( "Confirm -c is NOT set", !cl.hasOption("c") );
-        assertTrue( "Confirm NO extra args", cl.getArgList().size() == 0);
+        assertTrue( "Confirm NO extra args", cl.getArgList().isEmpty());
     }
 
     @Test
diff --git a/src/test/java/org/apache/commons/cli/ParserTestCase.java b/src/test/java/org/apache/commons/cli/ParserTestCase.java
index 2a16b9c..a32e254 100644
--- a/src/test/java/org/apache/commons/cli/ParserTestCase.java
+++ b/src/test/java/org/apache/commons/cli/ParserTestCase.java
@@ -227,7 +227,7 @@ public abstract class ParserTestCase
 
         assertTrue("Confirm -b is set", cl.hasOption('b'));
         assertEquals("Confirm -b is set", "foo", cl.getOptionValue('b'));
-        assertTrue("Confirm no extra args: " + cl.getArgList().size(), cl.getArgList().size() == 0);
+        assertTrue("Confirm no extra args: " + cl.getArgList().size(), cl.getArgList().isEmpty());
     }
 
     @Test
@@ -676,7 +676,7 @@ public abstract class ParserTestCase
         assertTrue("Confirm -a is NOT set", !cl.hasOption("a"));
         assertTrue("Confirm -b is set", cl.hasOption("b"));
         assertTrue("Confirm arg of -b", cl.getOptionValue("b").equals("file"));
-        assertTrue("Confirm NO of extra args", cl.getArgList().size() == 0);
+        assertTrue("Confirm NO of extra args", cl.getArgList().isEmpty());
     }
 
     @Test
@@ -693,7 +693,7 @@ public abstract class ParserTestCase
         assertTrue("Confirm -a is set", cl.hasOption("a"));
         assertTrue("Confirm -b is set", cl.hasOption("b"));
         assertTrue("Confirm arg of -b", cl.getOptionValue("b").equals("file"));
-        assertTrue("Confirm NO of extra args", cl.getArgList().size() == 0);
+        assertTrue("Confirm NO of extra args", cl.getArgList().isEmpty());
     }
 
     @Test