[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4135: Remove use of blacklist/whitelist terms

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4135:
URL: https://github.com/apache/cloudstack/pull/4135#discussion_r436558049



##########
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##########
@@ -94,8 +94,8 @@
     ConfigKey<Boolean> AllowUserViewDestroyedVM = new ConfigKey<>("Advanced", Boolean.class, "allow.user.view.destroyed.vm", "false",
             "Determines whether users can view their destroyed or expunging vm ", true, ConfigKey.Scope.Account);
 
-    static final ConfigKey<String> UserVMBlacklistedDetails = new ConfigKey<String>("Advanced", String.class,
-            "user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+    static final ConfigKey<String> UserVMDenyListedDetails = new ConfigKey<String>("Advanced", String.class,
+            "user.vm.DenyListed.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",

Review comment:
       not sure if this is an issue but naming convention fro settings is all lower case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org