[GitHub] [pulsar] tjiuming commented on a diff in pull request #17072: [monitoring][broker][metadata_store] add metrics for BatchMetadataStore

[GitBox <gi...@apache.org>]

tjiuming commented on code in PR #17072:
URL: https://github.com/apache/pulsar/pull/17072#discussion_r1002894565


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/batching/OpPut.java:
##########
@@ -49,4 +50,9 @@ public Type getType() {
     public int size() {
         return path.length() + (data != null ? data.length : 0);
     }
+
+    @Override

Review Comment:
   Yes, put it into a shared abstract class is better, but I think it is unnecessary to add an abstract  class for this function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org