[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635580#comment-16635580 ] 

ASF GitHub Bot commented on PIO-176:
------------------------------------

GitHub user saurabh3091 opened a pull request:

    https://github.com/apache/predictionio/pull/475

    [PIO-176] Hack in build.sbt for switching between Spark 1.x and 2.x s…

    - Removed unmanagedSourceDirectories in data module
    - refactored sqlSession code blocks to use SparkSession instead of SqlContext
    - removed PPythonEventStore.scala as it was not being used anywhere.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/saurabh3091/predictionio develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/predictionio/pull/475.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #475
    
----
commit 093a4d0ab778064f1349c21be7ff4d606d4ebbf4
Author: saurabh gulati <sa...@...>
Date:   2018-10-02T14:22:23Z

    [PIO-171] Hack in build.sbt for switching between Spark 1.x and 2.x should be cleaned up.

----


> Clean up unmanaged sources in the data module
> ---------------------------------------------
>
>                 Key: PIO-176
>                 URL: https://issues.apache.org/jira/browse/PIO-176
>             Project: PredictionIO
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.13.0
>            Reporter: Donald Szeto
>            Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141] should be removed. The source that it refers to should be refactored properly in the main source code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)