[GitHub] [couchdb] jaydoane commented on a change in pull request #3632: Fix FDB max_document_size, binary_chunk_size, and max_attachment_size checks

[GitBox <gi...@apache.org>]

jaydoane commented on a change in pull request #3632:
URL: https://github.com/apache/couchdb/pull/3632#discussion_r654834754



##########
File path: src/couch/src/couch_att.erl
##########
@@ -680,11 +680,20 @@ is_compressible(Type) ->
 
 
 max_attachment_size() ->
-    case config:get("couchdb", "max_attachment_size", "infinity") of
-        "infinity" ->
-            infinity;
-        MaxAttSize ->
-            list_to_integer(MaxAttSize)
+    ConfigMaxAttSize = config:get_integer(
+                            "couchdb",
+                            "max_attachment_size",
+                            ?ATT_SIZE_LIMIT_BYTES
+                        ),

Review comment:
       Was this indentation intentional? I only ask because it's neither the current style of generally indenting 4 spaces from the previous line, nor I think really `erlfmt` style.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org