You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2017/11/29 09:23:34 UTC
kylin git commit: KYLIN-1044 Update the how to contribute page to
allow Github pull requests
Repository: kylin
Updated Branches:
refs/heads/document 20b82dd76 -> 1fb592695
KYLIN-1044 Update the how to contribute page to allow Github pull requests
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/1fb59269
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/1fb59269
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/1fb59269
Branch: refs/heads/document
Commit: 1fb592695e42bc60b40d174179fd4fad896d3a64
Parents: 20b82dd
Author: shaofengshi <sh...@apache.org>
Authored: Wed Nov 29 17:23:29 2017 +0800
Committer: shaofengshi <sh...@apache.org>
Committed: Wed Nov 29 17:23:29 2017 +0800
----------------------------------------------------------------------
website/_dev/howto_contribute.md | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/1fb59269/website/_dev/howto_contribute.md
----------------------------------------------------------------------
diff --git a/website/_dev/howto_contribute.md b/website/_dev/howto_contribute.md
index 951f2d5..4fb3505 100644
--- a/website/_dev/howto_contribute.md
+++ b/website/_dev/howto_contribute.md
@@ -56,9 +56,11 @@ $ ./dev-support/submit-patch.py -jid KYLIN-xxxxx -b master -srb
## Apply Patch
* Committer will review Pull Requests and Patches in JIRA regarding correctness, performance, design, coding style, test coverage
-* Discuss and revise if necessary
+* Discuss and revise if necessary;
* Finally committer merge code into target branch
- * We use `git rebase` to ensure the merged result is a streamline of commits.
+ * For a git patch, use "git am -s -3 patch-file" command to apply;
+ * If it is from a github Pull Request, need add "This closes #<PR NUMBER>" as part of the commit messages. This will allow ASF Git bot to close the PR.
+ * Use `git rebase` to ensure the merged result is a streamline of commits.
## Making Document Changes