[GitHub] mistercrunch commented on issue #5686: [bugfix] Improve column name case alignment logic

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #5686: [bugfix] Improve column name case alignment logic
URL: https://github.com/apache/incubator-superset/pull/5686#issuecomment-414749518
 
 
   I feel like all of this is getting pretty messy and I'm starting to think we need a higher level refactor. Instead of mutating dataframe columns names, I feel like we should target SQLAlchemy labels (aliases) (upstream).
   
   This would mean that everywhere where we create a SQLA label we'd send it through a db_engine_spec `normalize_sqla_label` method. This also means that we need to also systematically do this every time we access a column in a dataframe.
   
   Now for the Druid connector there's no `db_engine_spec` as it's a SQLA construct. Maybe BaseViz can register a `self.normalize_label()` that points to `db_engine_spec.normalize_sqla_label` for the sqla connector, and points to a no-op for the druid connector.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org