You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/31 07:04:22 UTC

[GitHub] [avro] martin-g commented on a change in pull request #1484: AVRO-3334 Updated GetNullableType to simplify execution

martin-g commented on a change in pull request #1484:
URL: https://github.com/apache/avro/pull/1484#discussion_r795387028



##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGen.cs
##########
@@ -989,29 +990,20 @@ internal static string getType(Schema schema, bool nullible, ref bool nullibleEn
         /// <returns>
         /// schema that is nullable.
         /// </returns>
-        public static Schema getNullableType(UnionSchema schema)

Review comment:
       Since this is a public method we need to deprecate the old method for some time/releases.
   The old method should delegate to the new one. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org