[jira] [Commented] (KAFKA-3383) Producer should not remove an in flight request before successfully parsing the response.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269599#comment-15269599 ] 

ASF GitHub Bot commented on KAFKA-3383:
---------------------------------------

Github user zhuchen1018 closed the pull request at:

    https://github.com/apache/kafka/pull/1050


> Producer should not remove an in flight request before successfully parsing the response.
> -----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-3383
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3383
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.9.0.0
>            Reporter: Jiangjie Qin
>            Assignee: chen zhu
>            Priority: Critical
>             Fix For: 0.10.1.0
>
>
> In the NetworkClient, we remove the in flight request before we successfully parse the response. If the response parse failed, the request will not be fulfilled but just lost. For a producer request, that means the callback of the messages won't be fired forever.
> We should only remove the in flight request after response parsing succeeds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)