[jira] [Commented] (BEAM-122) GlobalWindow and allowedLateness can cause inconsistent timer interpretation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310973#comment-15310973 ] 

ASF GitHub Bot commented on BEAM-122:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/407


> GlobalWindow and allowedLateness can cause inconsistent timer interpretation 
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-122
>                 URL: https://issues.apache.org/jira/browse/BEAM-122
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields
>
> In ReduceFnRunner we have code such as
>    window.getMaxTimestamp().plus(windowingStrategy.getAllowedLateness())
> If window is global then maxTimestamp will be BoundedWindow.TIMESTAMP_MAX_VALUE.
> Meanwhile, timestamps beyond BoundedWindow.TIMESTAMP_MAX_VALUE will be clipped in most runners.
> This could cause the time of an expected timer (eg for garbage collection) to not match the actual time of a fired timer.
> We should either make non-zero allowedLateness on the Global window illegal (probably obnoxious) or explicitly clip it to zero.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)